You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/22 14:54:10 UTC
[GitHub] [flink] kezhuw opened a new pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishmentc]
kezhuw opened a new pull request #14466:
URL: https://github.com/apache/flink/pull/14466
## What is the purpose of the change
Reuse `SimpleJdbcConnectionProvider` for jdbc connection establishment.
## Brief change log
- Add `SimpleJdbcConnectionProvider.closeConnection` to close cached connection and declare that `SimpleJdbcConnectionProvider` is `NotThreadSafe`.
- Migrate jdbc InputFormat/LookupFunction to `SimpleJdbcConnectionProvider` for connection establishment.
- Throw `NullPointerException` instead of `IllegalArgumentException` if required arguments is null in `JdbcInputFormatBuilder` and `JdbcRowDataInputFormat.Builder`.
## Verifying this change
This change is already covered by existing tests:
* `JdbcInputFormatTest`
* `JdbcRowDataInputFormatTest`
This change added tests and can be verified as follows:
* `SimpleJdbcConnectionProviderTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
## Found other issues:
* Name inconsistence: `drivername` or `driverName` ?
* 0 is valid for `Statement.setFetchSize`, but `JdbcInputFormat` and `JdbcRowDataInputFormat` complains on this. It may not be important if all its usages are internal, but noticed that`JdbcInputFormat` is `Experimental`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishmentc]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 844cd0aee645f77f0c01e09614ad6e6cecc58837 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189)
* 93f836cbe23b55502113b33a6ca08f613ed1a480 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
}, {
"hash" : "cdb692019548197320d8e058c386e177fa180495",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253",
"triggerID" : "cdb692019548197320d8e058c386e177fa180495",
"triggerType" : "PUSH"
}, {
"hash" : "265349b7e273ffcc388f37fd31248eb37e271550",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11301",
"triggerID" : "265349b7e273ffcc388f37fd31248eb37e271550",
"triggerType" : "PUSH"
}, {
"hash" : "cfb29832f3281af5b385f0ef87f17875224f474e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11336",
"triggerID" : "cfb29832f3281af5b385f0ef87f17875224f474e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cfb29832f3281af5b385f0ef87f17875224f474e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11336)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kezhuw commented on a change in pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
kezhuw commented on a change in pull request #14466:
URL: https://github.com/apache/flink/pull/14466#discussion_r548527255
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/connection/JdbcConnectionProvider.java
##########
@@ -20,13 +20,40 @@
import org.apache.flink.annotation.Internal;
import java.sql.Connection;
+import java.sql.SQLException;
/**
* JDBC connection provider.
*/
@Internal
public interface JdbcConnectionProvider {
- Connection getConnection() throws Exception;
+ /**
+ * Get existing connection.
+ *
+ * @return existing connection
+ */
+ Connection getExistingConnection();
Review comment:
This method currently exist for reasons:
* Bypass java checked exception restriction and serve as drop-in replacement for old `connection` field in migrating classes.
* Test access with no side effect to wrapped connection in `JdbcInputFormat.getDbConn`, `AbstractJdbcOutputFormat.getConnection`, `JdbcLookupFunction.getDbConnection` and `JdbcRowDataLookupFunction.getDbConnection` without resort to cast or additional `VisibleForTesting`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kezhuw commented on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
kezhuw commented on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-751249646
@wuchong I have squashed and rebased all commits on latest master. Please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
}, {
"hash" : "cdb692019548197320d8e058c386e177fa180495",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253",
"triggerID" : "cdb692019548197320d8e058c386e177fa180495",
"triggerType" : "PUSH"
}, {
"hash" : "265349b7e273ffcc388f37fd31248eb37e271550",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11301",
"triggerID" : "265349b7e273ffcc388f37fd31248eb37e271550",
"triggerType" : "PUSH"
}, {
"hash" : "cfb29832f3281af5b385f0ef87f17875224f474e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11336",
"triggerID" : "cfb29832f3281af5b385f0ef87f17875224f474e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 265349b7e273ffcc388f37fd31248eb37e271550 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11301)
* cfb29832f3281af5b385f0ef87f17875224f474e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11336)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14466:
URL: https://github.com/apache/flink/pull/14466#discussion_r548424180
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/connection/JdbcConnectionProvider.java
##########
@@ -20,13 +20,40 @@
import org.apache.flink.annotation.Internal;
import java.sql.Connection;
+import java.sql.SQLException;
/**
* JDBC connection provider.
*/
@Internal
public interface JdbcConnectionProvider {
- Connection getConnection() throws Exception;
+ /**
+ * Get existing connection.
+ *
+ * @return existing connection
+ */
+ Connection getExistingConnection();
- Connection reestablishConnection() throws Exception;
+ /**
+ * Get existing connection or establish an new one if there is none.
+ *
+ * @return existing connection or newly established connection
+ * @throws SQLException sql exception
+ * @throws ClassNotFoundException driver class not found
+ */
+ Connection getConnection() throws SQLException, ClassNotFoundException;
Review comment:
What do you think about rename this method to `getOrCreateConnection` to make the create/establish behavior more explicitly?
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/connection/JdbcConnectionProvider.java
##########
@@ -20,13 +20,40 @@
import org.apache.flink.annotation.Internal;
import java.sql.Connection;
+import java.sql.SQLException;
/**
* JDBC connection provider.
*/
@Internal
public interface JdbcConnectionProvider {
- Connection getConnection() throws Exception;
+ /**
+ * Get existing connection.
+ *
+ * @return existing connection
+ */
+ Connection getExistingConnection();
Review comment:
Is this method necessary? Can users use `getConnection` instead?
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/AbstractJdbcOutputFormat.java
##########
@@ -72,15 +70,7 @@ public void close() {
}
private void closeDbConnection() {
Review comment:
Maybe we don't need this method anymore, we can directly invoke `connectionProvider.closeConnection` in `close()`.
The same to `establishConnection`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kezhuw commented on a change in pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
kezhuw commented on a change in pull request #14466:
URL: https://github.com/apache/flink/pull/14466#discussion_r548872516
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/connection/JdbcConnectionProvider.java
##########
@@ -20,13 +20,40 @@
import org.apache.flink.annotation.Internal;
import java.sql.Connection;
+import java.sql.SQLException;
/**
* JDBC connection provider.
*/
@Internal
public interface JdbcConnectionProvider {
- Connection getConnection() throws Exception;
+ /**
+ * Get existing connection.
+ *
+ * @return existing connection
+ */
+ Connection getExistingConnection();
Review comment:
`@Nullable` added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-751150556
Btw, I just merged #14387 which added `isConnectionValid` method to `JdbcConnectionProvider`. Could you rebase the branch and adapt the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14466:
URL: https://github.com/apache/flink/pull/14466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
}, {
"hash" : "cdb692019548197320d8e058c386e177fa180495",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253",
"triggerID" : "cdb692019548197320d8e058c386e177fa180495",
"triggerType" : "PUSH"
}, {
"hash" : "265349b7e273ffcc388f37fd31248eb37e271550",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11301",
"triggerID" : "265349b7e273ffcc388f37fd31248eb37e271550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 265349b7e273ffcc388f37fd31248eb37e271550 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11301)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kezhuw commented on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
kezhuw commented on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-750881215
@wuchong I have pushed fixup commits to address your review comments. Please take a look and check whether it solves your concerns, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishmentc]
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749580478
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 844cd0aee645f77f0c01e09614ad6e6cecc58837 (Tue Dec 22 14:55:55 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
}, {
"hash" : "cdb692019548197320d8e058c386e177fa180495",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253",
"triggerID" : "cdb692019548197320d8e058c386e177fa180495",
"triggerType" : "PUSH"
}, {
"hash" : "265349b7e273ffcc388f37fd31248eb37e271550",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "265349b7e273ffcc388f37fd31248eb37e271550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdb692019548197320d8e058c386e177fa180495 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253)
* 265349b7e273ffcc388f37fd31248eb37e271550 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
}, {
"hash" : "cdb692019548197320d8e058c386e177fa180495",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cdb692019548197320d8e058c386e177fa180495",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93f836cbe23b55502113b33a6ca08f613ed1a480 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201)
* cdb692019548197320d8e058c386e177fa180495 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14466:
URL: https://github.com/apache/flink/pull/14466#discussion_r548779793
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/connection/JdbcConnectionProvider.java
##########
@@ -20,13 +20,40 @@
import org.apache.flink.annotation.Internal;
import java.sql.Connection;
+import java.sql.SQLException;
/**
* JDBC connection provider.
*/
@Internal
public interface JdbcConnectionProvider {
- Connection getConnection() throws Exception;
+ /**
+ * Get existing connection.
+ *
+ * @return existing connection
+ */
+ Connection getExistingConnection();
Review comment:
That makes sense. Then I would suggest to add `@Nullable` annotation on the return type or check null in the implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
}, {
"hash" : "cdb692019548197320d8e058c386e177fa180495",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253",
"triggerID" : "cdb692019548197320d8e058c386e177fa180495",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93f836cbe23b55502113b33a6ca08f613ed1a480 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201)
* cdb692019548197320d8e058c386e177fa180495 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishmentc]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 844cd0aee645f77f0c01e09614ad6e6cecc58837 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189)
* 93f836cbe23b55502113b33a6ca08f613ed1a480 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
}, {
"hash" : "cdb692019548197320d8e058c386e177fa180495",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253",
"triggerID" : "cdb692019548197320d8e058c386e177fa180495",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdb692019548197320d8e058c386e177fa180495 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishmentc]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 844cd0aee645f77f0c01e09614ad6e6cecc58837 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishmentc]
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 844cd0aee645f77f0c01e09614ad6e6cecc58837 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kezhuw commented on a change in pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
kezhuw commented on a change in pull request #14466:
URL: https://github.com/apache/flink/pull/14466#discussion_r548518932
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/connection/JdbcConnectionProvider.java
##########
@@ -20,13 +20,40 @@
import org.apache.flink.annotation.Internal;
import java.sql.Connection;
+import java.sql.SQLException;
/**
* JDBC connection provider.
*/
@Internal
public interface JdbcConnectionProvider {
- Connection getConnection() throws Exception;
+ /**
+ * Get existing connection.
+ *
+ * @return existing connection
+ */
+ Connection getExistingConnection();
- Connection reestablishConnection() throws Exception;
+ /**
+ * Get existing connection or establish an new one if there is none.
+ *
+ * @return existing connection or newly established connection
+ * @throws SQLException sql exception
+ * @throws ClassNotFoundException driver class not found
+ */
+ Connection getConnection() throws SQLException, ClassNotFoundException;
Review comment:
I had this tendence too and already had a fixup commit in local, I will push that commit soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kezhuw commented on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment]
Posted by GitBox <gi...@apache.org>.
kezhuw commented on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749863470
@flinkbot attention @wuchong @rkhachatryan @leonardBang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kezhuw commented on a change in pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
kezhuw commented on a change in pull request #14466:
URL: https://github.com/apache/flink/pull/14466#discussion_r548527759
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/AbstractJdbcOutputFormat.java
##########
@@ -72,15 +70,7 @@ public void close() {
}
private void closeDbConnection() {
Review comment:
`closeDbConnection` and `establishConnection` is removed in fixup commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
}, {
"hash" : "cdb692019548197320d8e058c386e177fa180495",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253",
"triggerID" : "cdb692019548197320d8e058c386e177fa180495",
"triggerType" : "PUSH"
}, {
"hash" : "265349b7e273ffcc388f37fd31248eb37e271550",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11301",
"triggerID" : "265349b7e273ffcc388f37fd31248eb37e271550",
"triggerType" : "PUSH"
}, {
"hash" : "cfb29832f3281af5b385f0ef87f17875224f474e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cfb29832f3281af5b385f0ef87f17875224f474e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 265349b7e273ffcc388f37fd31248eb37e271550 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11301)
* cfb29832f3281af5b385f0ef87f17875224f474e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishment
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
}, {
"hash" : "cdb692019548197320d8e058c386e177fa180495",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253",
"triggerID" : "cdb692019548197320d8e058c386e177fa180495",
"triggerType" : "PUSH"
}, {
"hash" : "265349b7e273ffcc388f37fd31248eb37e271550",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11301",
"triggerID" : "265349b7e273ffcc388f37fd31248eb37e271550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdb692019548197320d8e058c386e177fa180495 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11253)
* 265349b7e273ffcc388f37fd31248eb37e271550 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11301)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14466: [FLINK-20657][connectors/jdbc] Migrate jdbc InputFormat/LookupFunction to SimpleJdbcConnectionProvider for connection establishmentc]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14466:
URL: https://github.com/apache/flink/pull/14466#issuecomment-749592580
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11189",
"triggerID" : "844cd0aee645f77f0c01e09614ad6e6cecc58837",
"triggerType" : "PUSH"
}, {
"hash" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201",
"triggerID" : "93f836cbe23b55502113b33a6ca08f613ed1a480",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93f836cbe23b55502113b33a6ca08f613ed1a480 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11201)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org