[GitHub] [zeppelin] zjffdu commented on a change in pull request #3411: ZEPPELIN-4272: Zeppelin fails to compile when hadoop3 is enabled

[GitBox <gi...@apache.org>]

zjffdu commented on a change in pull request #3411: ZEPPELIN-4272: Zeppelin fails to compile when hadoop3 is enabled
URL: https://github.com/apache/zeppelin/pull/3411#discussion_r309534032
 
 

 ##########
 File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/FileSystemStorage.java
 ##########
 @@ -60,16 +59,25 @@
   public FileSystemStorage(ZeppelinConfiguration zConf, String path) throws IOException {
     this.zConf = zConf;
     this.hadoopConf = new Configuration();
+    URI zepConfigURI;
+
+    zepConfigURI = getURI(path, "Failed to get URI path");
     // disable checksum for local file system. because interpreter.json may be updated by
     // non-hadoop filesystem api
     // disable caching for file:// scheme to avoid getting LocalFS which does CRC checks
+
     this.hadoopConf.setBoolean("fs.file.impl.disable.cache", true);
-    this.hadoopConf.set("fs.file.impl", RawLocalFileSystem.class.getName());
 
 Review comment:
   @bhavikpatel9977 One approach I can think of is adding one extra configuration such as `zeppelin.config.storage.useS3a`, by default it is false. 
   ```
   if (!useS3a) {
     this.hadoopConf.set("fs.file.impl", RawLocalFileSystem.class.getName());
   }
   ```
   
   This way we can not only solve your issue but also won't break other user cases. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services