You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/07 12:02:09 UTC
[GitHub] [kafka] tamara-skokova opened a new pull request #11573: KAFKA-13507: GlobalProcessor ignores user specified names
tamara-skokova opened a new pull request #11573:
URL: https://github.com/apache/kafka/pull/11573
Use the name specified via `consumed` parameter in `InternalStreamsBuilder#addGlobalStore` method for initializing the source name and processor name. If not specified, the names are generated.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tamara-skokova commented on pull request #11573: KAFKA-13507: GlobalProcessor ignores user specified names
Posted by GitBox <gi...@apache.org>.
tamara-skokova commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-988484139
@showuon, thanks, added a test that verifies the default names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #11573: KAFKA-13507: GlobalProcessor ignores user specified names
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-988225508
Failures unrelated to this PR - kicked off another build
- JDK 8 and Scala 2.12 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testTopicPartition, Security=PLAINTEXT
- JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.EosV2UpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosV2[true]
- JDK 17 and Scala 2.13 / kafka.server.ReplicaManagerTest.[1] usesTopicIds=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #11573: KAFKA-13507: GlobalProcessor ignores user specified names
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-989917167
Thanks @tamara-skokova for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #11573: KAFKA-13507: GlobalProcessor ignores user specified names
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-989875505
Java 8 and Java 11 passed
Java 17 failure unrelated - `org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveNamedTopologyToRunningApplicationWithMultipleNodesAndResetsOffsets`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11573: KAFKA-13507: GlobalProcessor ignores user specified names
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#discussion_r764516991
##########
File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
##########
@@ -998,6 +999,23 @@ public void shouldUseSpecifiedNameForAggregateOperationGivenTable() {
STREAM_OPERATION_NAME);
}
+ @Test
+ public void shouldUseSpecifiedNameForGlobalStoreProcessor() {
Review comment:
I didn't see there is tests for `GlobalStoreProcessor` using default name, right? That is, a test to create global store by `addGlobalStore` with `Consumed` instance without specifying a custom name, and verify the names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #11573: KAFKA-13507: GlobalProcessor ignores user specified names
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-989915792
merged #11573 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #11573: KAFKA-13507: GlobalProcessor ignores user specified names
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-989303922
We can merge this after we get a green build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck merged pull request #11573: KAFKA-13507: GlobalProcessor ignores user specified names
Posted by GitBox <gi...@apache.org>.
bbejeck merged pull request #11573:
URL: https://github.com/apache/kafka/pull/11573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org