[GitHub] [superset] justinpark commented on pull request #22050: chore(sqllab): Dimming status icon for running sql

[GitBox <gi...@apache.org>]

justinpark commented on PR #22050:
URL: https://github.com/apache/superset/pull/22050#issuecomment-1307708595

   > Woot! I never realized that the icon changed. justinpark rather than flashing I was wondering whether a different color would be more intuitive, i.e.,
   > 
   > 1. Grey: Not yet started
   > 2. Blue: In progress*
   > 3. Green: Success
   > 4. Red: Failed
   > 
   > Note people are red/green colorblind so maybe having a check-mark/x-mark inside the circle would help to distinguish between (3) and (4).
   > 
   > * I think blue is likely better than orange as orange normally implies warning.
   
   @john-bodley that's good idea. I updated the icons accordingly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org