You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2022/01/12 18:14:20 UTC

[GitHub] [jmeter] SampathKumarAmex opened a new pull request #691: "grgit" dependency moved to maven central

SampathKumarAmex opened a new pull request #691:
URL: https://github.com/apache/jmeter/pull/691


   ## Description
   Upgrading the plugin to latest version which is available in maven central. Please use the notes [here](https://github.com/ajoberstar/grgit).
   
   ## Motivation and Context
   I was unable to build the code as the `grgit` dependency couldn't be pulled from `JCenter`. Looks like the old versions are moved to `bintray-backup`. So, it make sense to move to the latest version (patch upgrade) which is available in maven central. Please refer this [link](https://github.com/ajoberstar/grgit) for more details. 
   
   ## How Has This Been Tested?
   n/a - Build issue
   
   ## Screenshots (if appropriate):
   n/a
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate -->
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [X] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] vlsi commented on pull request #691: Update grgit to 4.1.1 (from 4.1.0)

Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #691:
URL: https://github.com/apache/jmeter/pull/691#issuecomment-1046712595


   For reference, grgit-gradle 5.0.0 is Java 11+
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] vlsi commented on pull request #691: Update grgit to 4.1.1 (from 4.1.0)

Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #691:
URL: https://github.com/apache/jmeter/pull/691#issuecomment-1016485123


   @SampathKumarAmex , would you please squash the commits?
   Unfortunately, GitHub's "squash and merge" can't be used as it loses history.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] codecov-commenter edited a comment on pull request #691: Update grgit to 4.1.1 (from 4.1.0)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #691:
URL: https://github.com/apache/jmeter/pull/691#issuecomment-1011399244


   # [Codecov](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#691](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e91820a) into [master](https://codecov.io/gh/apache/jmeter/commit/af7fc4d56bffab352843cc87514ab9ed19bdad32?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af7fc4d) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/691/graphs/tree.svg?width=650&height=150&src=pr&token=6Q7CI1wFSh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #691   +/-   ##
   =========================================
     Coverage     55.59%   55.59%           
     Complexity    10336    10336           
   =========================================
     Files          1059     1059           
     Lines         65045    65050    +5     
     Branches       7399     7401    +2     
   =========================================
   + Hits          36160    36163    +3     
   - Misses        26336    26337    +1     
   - Partials       2549     2550    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9yZXBvcnRlcnMvU3VtbWFyaXNlci5qYXZh) | `90.07% <0.00%> (-0.77%)` | :arrow_down: |
   | [...rg/apache/jmeter/assertions/JSONPathAssertion.java](https://codecov.io/gh/apache/jmeter/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9hc3NlcnRpb25zL0pTT05QYXRoQXNzZXJ0aW9uLmphdmE=) | `80.85% <0.00%> (-0.05%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [af7fc4d...e91820a](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] codecov-commenter commented on pull request #691: "grgit" dependency moved to maven central

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #691:
URL: https://github.com/apache/jmeter/pull/691#issuecomment-1011399244


   # [Codecov](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#691](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d38154) into [master](https://codecov.io/gh/apache/jmeter/commit/af7fc4d56bffab352843cc87514ab9ed19bdad32?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af7fc4d) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/691/graphs/tree.svg?width=650&height=150&src=pr&token=6Q7CI1wFSh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #691      +/-   ##
   ============================================
   - Coverage     55.59%   55.59%   -0.01%     
   + Complexity    10336    10335       -1     
   ============================================
     Files          1059     1059              
     Lines         65045    65045              
     Branches       7399     7399              
   ============================================
   - Hits          36160    36159       -1     
   - Misses        26336    26337       +1     
     Partials       2549     2549              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9yZXBvcnRlcnMvU3VtbWFyaXNlci5qYXZh) | `90.07% <0.00%> (-0.77%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [af7fc4d...3d38154](https://codecov.io/gh/apache/jmeter/pull/691?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] vlsi commented on a change in pull request #691: "grgit" dependency moved to maven central

Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #691:
URL: https://github.com/apache/jmeter/pull/691#discussion_r783338124



##########
File path: buildSrc/checksum.xml
##########
@@ -26,7 +26,6 @@
     <trusted-key id='6449005f96bc97a3' group='de.undercouch' />
     <trusted-key id='379ce192d401ab61' group='info.picocli' />
     <trusted-key id='efe8086f9e93774e' group='junit' />
-    <trusted-key id='c84125c13bf6f2f2' group='org.ajoberstar.grgit' />

Review comment:
       Is there a reason you removed the PGP key reference?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] SampathKumarAmex commented on pull request #691: Update grgit to 4.1.1 (from 4.1.0)

Posted by GitBox <gi...@apache.org>.
SampathKumarAmex commented on pull request #691:
URL: https://github.com/apache/jmeter/pull/691#issuecomment-1022365838


   > @SampathKumarAmex , would you please squash the commits? Unfortunately, GitHub's "squash and merge" can't be used as it loses history.
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] SampathKumarAmex commented on a change in pull request #691: "grgit" dependency moved to maven central

Posted by GitBox <gi...@apache.org>.
SampathKumarAmex commented on a change in pull request #691:
URL: https://github.com/apache/jmeter/pull/691#discussion_r783438354



##########
File path: buildSrc/checksum.xml
##########
@@ -26,7 +26,6 @@
     <trusted-key id='6449005f96bc97a3' group='de.undercouch' />
     <trusted-key id='379ce192d401ab61' group='info.picocli' />
     <trusted-key id='efe8086f9e93774e' group='junit' />
-    <trusted-key id='c84125c13bf6f2f2' group='org.ajoberstar.grgit' />

Review comment:
       Thanks! I have reverted this line after reading [this](https://github.com/apache/jmeter/pull/488)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org