You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2016/02/18 23:48:21 UTC
Review Request 43741: Fixed symlink generation for DESTDIR installs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/
-----------------------------------------------------------
Review request for mesos and James Peach.
Bugs: MESOS-4714
https://issues.apache.org/jira/browse/MESOS-4714
Repository: mesos
Description
-------
The install-data-hook was missing the '$(DESTDIR)' prefix.
Diffs
-----
src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b
Diff: https://reviews.apache.org/r/43741/diff/
Testing
-------
Ran `make install DESTDIR=/tmp` with and without the patch.
Thanks,
Kapil Arya
Re: Review Request 43741: Fixed symlink generation for DESTDIR
installs.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119732
-----------------------------------------------------------
Ship it!
Good catch.
- James Peach
On Feb. 18, 2016, 10:48 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43741/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 10:48 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-4714
> https://issues.apache.org/jira/browse/MESOS-4714
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The install-data-hook was missing the '$(DESTDIR)' prefix.
>
>
> Diffs
> -----
>
> src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b
>
> Diff: https://reviews.apache.org/r/43741/diff/
>
>
> Testing
> -------
>
> Ran `make install DESTDIR=/tmp` with and without the patch.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 43741: Fixed symlink generation for DESTDIR
installs.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119736
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 18, 2016, 10:49 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43741/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 10:49 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-4714
> https://issues.apache.org/jira/browse/MESOS-4714
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The install-data-hook was missing the '$(DESTDIR)' prefix.
>
>
> Diffs
> -----
>
> src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b
>
> Diff: https://reviews.apache.org/r/43741/diff/
>
>
> Testing
> -------
>
> Ran `make install DESTDIR=/tmp` with and without the patch.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 43741: Fixed symlink generation for DESTDIR
installs.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119737
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Feb. 18, 2016, 10:49 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43741/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 10:49 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-4714
> https://issues.apache.org/jira/browse/MESOS-4714
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The install-data-hook was missing the '$(DESTDIR)' prefix.
>
>
> Diffs
> -----
>
> src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b
>
> Diff: https://reviews.apache.org/r/43741/diff/
>
>
> Testing
> -------
>
> Ran `make install DESTDIR=/tmp` with and without the patch.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 43741: Fixed symlink generation for DESTDIR
installs.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119734
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On Feb. 18, 2016, 10:49 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43741/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 10:49 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-4714
> https://issues.apache.org/jira/browse/MESOS-4714
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The install-data-hook was missing the '$(DESTDIR)' prefix.
>
>
> Diffs
> -----
>
> src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b
>
> Diff: https://reviews.apache.org/r/43741/diff/
>
>
> Testing
> -------
>
> Ran `make install DESTDIR=/tmp` with and without the patch.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 43741: Fixed symlink generation for DESTDIR
installs.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 5:49 p.m.)
Review request for mesos and James Peach.
Bugs: MESOS-4714
https://issues.apache.org/jira/browse/MESOS-4714
Repository: mesos
Description
-------
The install-data-hook was missing the '$(DESTDIR)' prefix.
Diffs (updated)
-----
src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b
Diff: https://reviews.apache.org/r/43741/diff/
Testing
-------
Ran `make install DESTDIR=/tmp` with and without the patch.
Thanks,
Kapil Arya