You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/14 21:33:05 UTC

[GitHub] [spark] gengliangwang commented on issue #26116: [SPARK-29107][SQL][TESTS][FollowUp] Move window_part1.sql to directory 'postgreSQL'

gengliangwang commented on issue #26116: [SPARK-29107][SQL][TESTS][FollowUp] Move window_part1.sql to directory 'postgreSQL'
URL: https://github.com/apache/spark/pull/26116#issuecomment-541934617
 
 
   I got this error after renaming the file 
   ```
   +org.apache.spark.sql.catalyst.parser.ParseException
   +
   +no viable alternative at input 'year'(line 3, pos 59)
   +
   +== SQL ==
   +SELECT empno, depname, salary, bonus, depadj, MIN(bonus) OVER (ORDER BY empno), MAX(depadj) OVER () FROM(
   +SELECT *,
   +  CASE WHEN enroll_date < '2008-01-01' THEN 2008 - extract(year FROM enroll_date) END * 500 AS bonus,
   +-----------------------------------------------------------^^^
   +  CASE WHEN
   +    AVG(salary) OVER (PARTITION BY depname) < salary
   +    THEN 200 END AS depadj FROM empsalary
   +  )s
    ```
   
   
   Also, it fails the ANSI table insertion policy:
   https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112055/consoleFull
   
   I am thinking about reverting the PR https://github.com/apache/spark/pull/25816. After https://github.com/apache/spark/pull/26107 is merged, we can manage to add the window_part1.sql back correctly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org