[GitHub] [ignite-3] zstan commented on a diff in pull request #2128: IGNITE-19540 Add Basic Data Streamer

["zstan (via GitHub)" <gi...@apache.org>]

zstan commented on code in PR #2128:
URL: https://github.com/apache/ignite-3/pull/2128#discussion_r1214088159


##########
modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTable.java:
##########
@@ -72,9 +72,9 @@ public class ClientTable implements Table {
 
     private final Object partitionAssignmentLock = new Object();
 
-    private CompletableFuture<List<String>> partitionAssignment = null;
+    private volatile CompletableFuture<List<String>> partitionAssignment = null;
 
-    private long partitionAssignmentVersion = -1;
+    private volatile long partitionAssignmentVersion = -1;

Review Comment:
   why do you append volatile ? as i can see all usage is already under monitor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org