[GitHub] [druid] gianm commented on a change in pull request #9281: Add LookupJoinableFactory.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #9281: Add LookupJoinableFactory.
URL: https://github.com/apache/druid/pull/9281#discussion_r373234827
 
 

 ##########
 File path: server/src/test/java/org/apache/druid/guice/JoinableFactoryModuleTest.java
 ##########
 @@ -63,7 +66,7 @@ public void testInjectDefaultBindingsShouldBeInjected()
   {
     Map<Class<? extends DataSource>, JoinableFactory> joinableFactories =
         injector.getInstance(Key.get(new TypeLiteral<Map<Class<? extends DataSource>, JoinableFactory>>() {}));
-    Assert.assertEquals(1, joinableFactories.size());
+    Assert.assertEquals(2, joinableFactories.size());
 
 Review comment:
   Sure, that sounds good, I'll add one in a followup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org