You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 11:33:48 UTC
[GitHub] [airflow] ashb opened a new pull request, #22858: Speed up `has_access` decorator by ~200ms
ashb opened a new pull request, #22858:
URL: https://github.com/apache/airflow/pull/22858
Using the ORM to create all the Role, Permission, Action and Resource objects, only to throw them all away _on every request_ is slow. And since we are now using the API more and more in the UI it's starting to get noticeable
This changes the `user.perm` property to issue a custom query that returns the tuple of action_name, permission_name we want, bypassing the ORM object inflation entirely, and since `user.roles` isn't needed in most requests we no longer eagerly load that.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #22858: Speed up `has_access` decorator by ~200ms
Posted by GitBox <gi...@apache.org>.
ashb merged PR #22858:
URL: https://github.com/apache/airflow/pull/22858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #22858: Speed up `has_access` decorator by ~200ms
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #22858:
URL: https://github.com/apache/airflow/pull/22858#issuecomment-1092768310
(I don't know if this slow down is a side-effect of @jhtimmins refactoring for 2.3.0, or something that has always been slow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22858: Speed up `has_access` decorator by ~200ms
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22858:
URL: https://github.com/apache/airflow/pull/22858#issuecomment-1093043450
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #22858: Speed up `has_access` decorator by ~200ms
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #22858:
URL: https://github.com/apache/airflow/pull/22858#discussion_r846295180
##########
airflow/www/fab_security/sqla/models.py:
##########
@@ -229,10 +229,24 @@ def is_anonymous(self):
@property
def perms(self):
- perms = set()
- for role in self.roles:
- perms.update((perm.action.name, perm.resource.name) for perm in role.permissions)
- return perms
+ if not self._perms_cache:
+ # Using the ORM here is _slow_ (Creating lots of objects to then throw them away) since this is in
+ # the path for every request. Avoid it if we can!
+ if current_app:
+ sm = current_app.appbuilder.sm
+ self._perms_cache: Set[Tuple[str, str]] = set(
+ sm.get_session.query(sm.action_model.name, sm.resource_model.name)
+ .join(sm.permission_model.action)
+ .join(sm.permission_model.resource)
+ .join(sm.permission_model.role)
+ .filter(sm.role_model.user.contains(g.user))
Review Comment:
```suggestion
.filter(sm.role_model.user.contains(self))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #22858: Speed up `has_access` decorator by ~200ms
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on PR #22858:
URL: https://github.com/apache/airflow/pull/22858#issuecomment-1093042140
> (I don't know if this slow down is a side-effect of @jhtimmins refactoring for 2.3.0, or something that has always been slow)
Yes to both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org