You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ti...@apache.org on 2019/12/20 22:24:23 UTC
[maven-surefire] branch master updated (db16777 -> d013902)
This is an automated email from the ASF dual-hosted git repository.
tibordigana pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git.
from db16777 plexus-java as a property to ease testing
new 83b1b98 fixed the grammar in new configuration parameter 'enableProcessChecker' in 3.0.0-M4
new d013902 a debug log printed in a condition only when necessary
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../org/apache/maven/plugin/failsafe/IntegrationTestMojo.java | 8 ++++----
.../java/org/apache/maven/plugin/surefire/SurefirePlugin.java | 8 ++++----
.../main/java/org/apache/maven/surefire/booter/ForkedBooter.java | 5 +----
3 files changed, 9 insertions(+), 12 deletions(-)
[maven-surefire] 02/02: a debug log printed in a condition only
when necessary
Posted by ti...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
commit d013902c0de20f83c6a85aa4fffbc2b6bd99af88
Author: tibordigana <ti...@apache.org>
AuthorDate: Fri Dec 20 23:24:04 2019 +0100
a debug log printed in a condition only when necessary
---
.../src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
index 9da6d9b..2701221 100644
--- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
+++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
@@ -198,15 +198,12 @@ public final class ForkedBooter
AtomicBoolean pingDone = new AtomicBoolean( true );
commandReader.addNoopListener( createPingHandler( pingDone ) );
PingScheduler pingMechanisms = new PingScheduler( createPingScheduler(), ppidChecker );
- if ( ppidChecker != null )
- {
- logger.debug( ppidChecker.toString() );
- }
ProcessCheckerType checkerType = startupConfiguration.getProcessChecker();
if ( ( checkerType == ALL || checkerType == NATIVE ) && pingMechanisms.pluginProcessChecker != null )
{
+ logger.debug( pingMechanisms.pluginProcessChecker.toString() );
Runnable checkerJob = processCheckerJob( pingMechanisms );
pingMechanisms.pingScheduler.scheduleWithFixedDelay( checkerJob, 0L, 1L, SECONDS );
}
[maven-surefire] 01/02: fixed the grammar in new configuration
parameter 'enableProcessChecker' in 3.0.0-M4
Posted by ti...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
commit 83b1b98f7eb7fda993a31d8dee964c3330d1cad4
Author: tibordigana <ti...@apache.org>
AuthorDate: Fri Dec 20 23:16:59 2019 +0100
fixed the grammar in new configuration parameter 'enableProcessChecker' in 3.0.0-M4
---
.../org/apache/maven/plugin/failsafe/IntegrationTestMojo.java | 8 ++++----
.../java/org/apache/maven/plugin/surefire/SurefirePlugin.java | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java b/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
index a5adc3c..e465bb2 100644
--- a/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
+++ b/maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
@@ -404,14 +404,14 @@ public class IntegrationTestMojo
* Since 3.0.0-M4 the process checkers are disabled.
* You can enable them namely by setting {@code ping} and {@code native} or {@code all} in this parameter.
* <br>
- * The checker is useful in situations when you kill the build on CI and you want the Surefire forked JVM to kill
- * the tests asap and free all handlers on the file system been previously used by the JVM and by the tests.
+ * The checker is useful in situations when you kill the build on a CI system and you want the Surefire forked JVM
+ * to kill the tests asap and free all handlers on the file system been previously used by the JVM and by the tests.
*
* <br>
*
* The {@code ping} should be safely used together with ZGC or Shenandoah Garbage Collector.
- * Due to the {@code ping} relies on timing of PING (triggered every 30 seconds), slow GC may pause
- * the timers and pretend that the parent process of the fork JVM does not exist.
+ * Due to the {@code ping} relies on timing of the PING (triggered every 30 seconds), slow GCs may pause
+ * the timers and pretend that the parent process of the forked JVM does not exist.
*
* <br>
*
diff --git a/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java b/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
index 17e9032..b39181a 100644
--- a/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
+++ b/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
@@ -385,14 +385,14 @@ public class SurefirePlugin
* Since 3.0.0-M4 the process checkers are disabled.
* You can enable them namely by setting {@code ping} and {@code native} or {@code all} in this parameter.
* <br>
- * The checker is useful in situations when you kill the build on CI and you want the Surefire forked JVM to kill
- * the tests asap and free all handlers on the file system been previously used by the JVM and by the tests.
+ * The checker is useful in situations when you kill the build on a CI system and you want the Surefire forked JVM
+ * to kill the tests asap and free all handlers on the file system been previously used by the JVM and by the tests.
*
* <br>
*
* The {@code ping} should be safely used together with ZGC or Shenandoah Garbage Collector.
- * Due to the {@code ping} relies on timing the PING (triggered every 30 seconds), slow GC may pause
- * the timers and pretend that the parent process of the fork JVM does not exist.
+ * Due to the {@code ping} relies on timing of the PING (triggered every 30 seconds), slow GCs may pause
+ * the timers and pretend that the parent process of the forked JVM does not exist.
*
* <br>
*