You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Jackson Yao (Jira)" <ji...@apache.org> on 2021/09/02 13:28:00 UTC

[jira] [Resolved] (HDDS-5710) add a separate RWlock for GrpcLogAppender

     [ https://issues.apache.org/jira/browse/HDDS-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jackson Yao resolved HDDS-5710.
-------------------------------
    Resolution: Won't Do

> add a separate RWlock for GrpcLogAppender
> -----------------------------------------
>
>                 Key: HDDS-5710
>                 URL: https://issues.apache.org/jira/browse/HDDS-5710
>             Project: Apache Ozone
>          Issue Type: Improvement
>            Reporter: Jackson Yao
>            Priority: Major
>
> in GrpcLogAppender.java,  `synchronized` is used for two purposes:
> 1 protect `wait()`
> 2 protect variables like  `pendingRequests`, `pending` , etc.
> i think it is better off add a separate RWLock for the second case , and keep `synchronized` only for wait and notify, thus any slow IO option will not block notify



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org