[jira] [Commented] (HBASE-20234) Expose in-memory compaction metrics

["Anastasia Braginsky (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426872#comment-16426872 ] 

Anastasia Braginsky commented on HBASE-20234:
---------------------------------------------

[~stack], I can take care for this issue. There are currently no per-store counters that I have described (number of in-memory-flushes, number of saved bytes), nor that they make it up to region-level. No problem to add them.

I have taken a look on the Region's Metrics design. It looks like the notion of Histogram (MetricHistogram) we can use well for in-memory-flushes history, saved bytes history. However, MetricsRegionServer's method updateFlush() appears to be invoked once in a while upon organized flush-to-disk.

As in-memory-flush is an asynchronous event (appearing from time to time on different stores), we will need to keep some new per-region periodic task to collect the per-store counters and transfer them to the Metrics. Alternatively we can coordinate the collection of the in-memory-flush counters to the flush-to-disk update, that already exists in the code. I am not sure it is good to bind those events. Any alternative ideas?

> Expose in-memory compaction metrics
> -----------------------------------
>
>                 Key: HBASE-20234
>                 URL: https://issues.apache.org/jira/browse/HBASE-20234
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: Anastasia Braginsky
>            Priority: Major
>
> Hard to glean insight from how well in-memory compaction is doing currently. It dumps stats into the logs but better if they were available to a dashboard. This issue is about exposing a couple of helpful counts. There are already by-region metrics. We can add a few for in-memory compaction (Help me out [~anastas]... what counts would be best to expose).
> Flush related metrics include....
> {code}
> Namespace_default_table_tsdb-tree_region_cfbf23e7330a1a2bbde031f9583d3415_metric_flushesQueuedCount: {
> description: "Number flushes requested/queued for this region",
> value: 0
> {
> description: "The number of cells flushed to disk",
> value: 0
> },
> {
> description: "The total amount of data flushed to disk, in bytes",
> value: 0
> },
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)