You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/16 13:01:12 UTC
[GitHub] [spark] zengruios opened a new pull request #31851: [BugFix]fix the bug in issue SPARK-34760.
zengruios opened a new pull request #31851:
URL: https://github.com/apache/spark/pull/31851
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
In JavaSparkSQLExample when excecute 'peopleDF.write().partitionBy("favorite_color").bucketBy(42,"name").saveAsTable("people_partitioned_bucketed");'
throws Exception: 'Exception in thread "main" org.apache.spark.sql.AnalysisException: partition column favorite_color is not defined in table people_partitioned_bucketed, defined table columns are: age, name;'
Change the column favorite_color to age.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Run JavaSparkSQLExample successfully.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
NO
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
test in JavaSparkSQLExample .
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31851: [SPARK-34760][EXAMPLES] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-802011948
@zengruios Thanks for your first contribution to Apache Spark.
I have added you as a contributor at the JIRA side, and SPARK-34760 has been assigned to you.
Thanks for the review, @dongjoon-hyun @maropu @HyukjinKwon
Merged to master/3.1/3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zengruios edited a comment on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
zengruios edited a comment on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800668326
@dongjoon-hyun, thanks for your suggestion, maybe the table's name should be changed to user_partitioned_bucketed, I will try to fix it like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-801958904
@yaooqinn maybe can you try merging this as a brand new committer :-)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zengruios commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
zengruios commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800703056
@maropu, @dongjoon-hyun, I have update it, can you review it again, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zengruios commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
zengruios commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800674358
@maropu, OK，I will merge them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31851: [MINOR] Correct an example error in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800239771
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31851: [SPARK-34760][EXAMPLES] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-802389732
late lgtm 👏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31851: [BugFix]fix the bug in issue SPARK-34760.
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800322720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-801963789
Improvements are not backported in general but looks like this is a bug fix in the example (reading from JIRA) which is usually backported. The JIRA states the affected versions are 3.0.1 and 3.1.1 so I would merge this to branch-3.1 and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-801965701
Yea, LGTM~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31851: [SPARK-34760][EXAMPLES] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-802058059
Congratulation, @zengruios and @yaooqinn .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800671299
Could you merge the https://github.com/apache/spark/pull/31852 fix into this PR? These issues are similar and minor, so merging them looks okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zengruios commented on pull request #31851: [MINOR][EXAMPLES] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
zengruios commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800668326
@dongjoon-hyun, thanks for you suggestion, maybe the table's name should be changed to user_partitioned_bucketed, I will try to fix it like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31851: [SPARK-34760][EXAMPLES] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-802033111
👏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn closed pull request #31851: [SPARK-34760][EXAMPLES] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #31851:
URL: https://github.com/apache/spark/pull/31851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31851: [MINOR] Correct an example error in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800338469
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800729667
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40712/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800715108
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136130/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31851: [SPARK-34760][EXAMPLES] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-801996284
My network is not in good condition at the moment. It took years to fetch and push this PR to master :(.. Now, it's fighting for branch-3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31851: [MINOR] Correct an example error in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800426397
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800675014
Thank you, @zengruios
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-801961498
thanks, @HyukjinKwon. I will merge this to master only, is it Okay?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31851: [MINOR] Correct an example error in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800375352
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136120/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31851: [MINOR] Correct an example error in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800338469
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40702/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31851: [SPARK-34760][EXAMPLES][MINOR] Replace `favorite_color` with `age` in JavaSQLDataSourceExample
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800715108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31851: [BugFix]fix the bug in issue SPARK-34760.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31851:
URL: https://github.com/apache/spark/pull/31851#issuecomment-800239771
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org