mesos git commit: Updated the committer doc regarding checking JIRA before committing.

[ji...@apache.org]

Repository: mesos
Updated Branches:
  refs/heads/master 80437f386 -> 833106f3b


Updated the committer doc regarding checking JIRA before committing.

Review: https://reviews.apache.org/r/34420


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/833106f3
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/833106f3
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/833106f3

Branch: refs/heads/master
Commit: 833106f3bc7795c6bc356d9cc5d3ab6139f93279
Parents: 80437f3
Author: Jie Yu <yu...@gmail.com>
Authored: Tue May 19 10:39:28 2015 -0700
Committer: Jie Yu <yu...@gmail.com>
Committed: Thu May 21 10:16:03 2015 -0700

----------------------------------------------------------------------
 docs/committing.md | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/833106f3/docs/committing.md
----------------------------------------------------------------------
diff --git a/docs/committing.md b/docs/committing.md
index 3aef7f2..eabc0aa 100644
--- a/docs/committing.md
+++ b/docs/committing.md
@@ -9,7 +9,9 @@ work with one during code review to get your changes committed.
 
 If you are a committer, here are some guidelines for committing changes:
 
-1. **Follow the format of commit messages**: we currently do not leverage
+1. **Check the JIRA ticket**: make sure there is no further discussion
+   needed regarding the approach used in the patch.
+2. **Follow the format of commit messages**: we currently do not leverage
    any tooling to enforce the format of messages, so:
     a. Be clear and explicit in the commit message.
     b. Include the link to the review (this will be done automatically if
@@ -20,14 +22,14 @@ If you are a committer, here are some guidelines for committing changes:
     c. Use 72 character columns. Note that we don't always have a 50
        character or less summary because that restriction tends to cause
        people to write poorly.
-2. **Keep the 'Author' intact**: `support/apply-review.sh` will handle
+3. **Keep the 'Author' intact**: `support/apply-review.sh` will handle
    this for you, but be careful when rebasing or ammending.
-3. **Never ever commit a merge**: always rebase instead, as appropriate.
+4. **Never ever commit a merge**: always rebase instead, as appropriate.
    Likewise, never 'force push'.
-4. **Don't break the build**: we support Linux and Mac OS X, however not
+5. **Don't break the build**: we support Linux and Mac OS X, however not
    all configurations are being tested in Jenkins, so be aware of that.
    Also, pay attention to the Jenkins review bot if it flags a review as
    breaking the build. Note that if you do break the build, the fixes are
    often small and inconsequential so don't worry about going through a
    review cycle for that, just fix things (but don't take that as a license
-   to "wait until the build fails to fix things").
\ No newline at end of file
+   to "wait until the build fails to fix things").