You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/06/06 03:08:47 UTC
[GitHub] [nifi] alopresto commented on a change in pull request #3514:
NIFI-6344 Add UpdateAttribute Failure Relationship
alopresto commented on a change in pull request #3514: NIFI-6344 Add UpdateAttribute Failure Relationship
URL: https://github.com/apache/nifi/pull/3514#discussion_r291003370
##########
File path: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes/UpdateAttribute.java
##########
@@ -30,11 +30,7 @@
import org.apache.nifi.annotation.documentation.CapabilityDescription;
import org.apache.nifi.annotation.documentation.Tags;
import org.apache.nifi.annotation.lifecycle.OnScheduled;
-import org.apache.nifi.components.PropertyDescriptor;
-import org.apache.nifi.components.PropertyValue;
-import org.apache.nifi.components.ValidationContext;
-import org.apache.nifi.components.ValidationResult;
-import org.apache.nifi.components.Validator;
+import org.apache.nifi.components.*;
Review comment:
We discourage star imports. I am in the process of adding this to our checkstyle definitions.
(I'm guessing your IDE did this automatically and invisibly. You can disable that in IntelliJ IDEA by setting **Preferences** > Editor > Code Style > Java > Imports > _Class count to use import with '*':_ to `999` and _Names count to use static import with '*':_ to `999`.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services