You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2009/03/03 19:42:56 UTC

[jira] Created: (HADOOP-5382) The new map/reduce api doesn't support combiners

The new map/reduce api doesn't support combiners
------------------------------------------------

                 Key: HADOOP-5382
                 URL: https://issues.apache.org/jira/browse/HADOOP-5382
             Project: Hadoop Core
          Issue Type: Bug
    Affects Versions: 0.20.0
            Reporter: Owen O'Malley
            Assignee: Owen O'Malley
            Priority: Blocker
             Fix For: 0.20.0


Currently, combiners are only called if they are defined using the old deprecated api. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5382) The new map/reduce api doesn't support combiners

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682852#action_12682852 ] 

Arun C Murthy commented on HADOOP-5382:
---------------------------------------

+1

> The new map/reduce api doesn't support combiners
> ------------------------------------------------
>
>                 Key: HADOOP-5382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5382
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: h5382.patch
>
>
> Currently, combiners are only called if they are defined using the old deprecated api. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5382) The new map/reduce api doesn't support combiners

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683241#action_12683241 ] 

Owen O'Malley commented on HADOOP-5382:
---------------------------------------

     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.


> The new map/reduce api doesn't support combiners
> ------------------------------------------------
>
>                 Key: HADOOP-5382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5382
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: h5382.patch, h5382.patch
>
>
> Currently, combiners are only called if they are defined using the old deprecated api. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5382) The new map/reduce api doesn't support combiners

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-5382:
----------------------------------

    Attachment: h5382.patch

This fixes a findbugs warning about a unused variable that I forgot to remove.

> The new map/reduce api doesn't support combiners
> ------------------------------------------------
>
>                 Key: HADOOP-5382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5382
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: h5382.patch, h5382.patch
>
>
> Currently, combiners are only called if they are defined using the old deprecated api. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5382) The new map/reduce api doesn't support combiners

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683262#action_12683262 ] 

Hadoop QA commented on HADOOP-5382:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12402417/h5382.patch
  against trunk revision 755589.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/102/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/102/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/102/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/102/console

This message is automatically generated.

> The new map/reduce api doesn't support combiners
> ------------------------------------------------
>
>                 Key: HADOOP-5382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5382
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: h5382.patch, h5382.patch
>
>
> Currently, combiners are only called if they are defined using the old deprecated api. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5382) The new map/reduce api doesn't support combiners

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-5382:
----------------------------------

    Attachment: h5382.patch

This patch pulls the combining functionality into an internal class with two implementations, one for the old style combiners and one for the new style. Old and new combiners can  mix and match with either new or old applications and therefore I removed the checks that forced them to be consistent. 

> The new map/reduce api doesn't support combiners
> ------------------------------------------------
>
>                 Key: HADOOP-5382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5382
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: h5382.patch
>
>
> Currently, combiners are only called if they are defined using the old deprecated api. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5382) The new map/reduce api doesn't support combiners

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-5382:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this.

> The new map/reduce api doesn't support combiners
> ------------------------------------------------
>
>                 Key: HADOOP-5382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5382
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: h5382.patch, h5382.patch
>
>
> Currently, combiners are only called if they are defined using the old deprecated api. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5382) The new map/reduce api doesn't support combiners

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12684005#action_12684005 ] 

Hudson commented on HADOOP-5382:
--------------------------------

Integrated in Hadoop-trunk #785 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/785/])
    

> The new map/reduce api doesn't support combiners
> ------------------------------------------------
>
>                 Key: HADOOP-5382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5382
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: h5382.patch, h5382.patch
>
>
> Currently, combiners are only called if they are defined using the old deprecated api. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5382) The new map/reduce api doesn't support combiners

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-5382:
----------------------------------

    Status: Patch Available  (was: Open)

> The new map/reduce api doesn't support combiners
> ------------------------------------------------
>
>                 Key: HADOOP-5382
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5382
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: h5382.patch
>
>
> Currently, combiners are only called if they are defined using the old deprecated api. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.