You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2026/06/18 05:11:47 UTC
(impala) 01/03: IMPALA-15058: Fix incorrect server_name startup flag in Python scripts
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit e1391bcf8869ee5f649bc30bd9988e24ba88e21d
Author: Shaunak5ach <sh...@cloudera.com>
AuthorDate: Mon Jun 15 21:09:30 2026 +0530
IMPALA-15058: Fix incorrect server_name startup flag in Python scripts
This patch updates the cluster orchestration layer and test configurations
to use the correct server_name startup flags. It ensures the parameters
properly align with the updated execution parameters.
Change-Id: I5e47ab7e82b2eb76c839380bf1e3c2090a732e87
Assisted-by: Gemini <https://gemini.google.com>
Reviewed-on: http://gerrit.cloudera.org:8080/24466
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
bin/start-impala-cluster.py | 4 ++--
tests/authorization/test_authorization.py | 24 ++++++++++++------------
tests/authorization/test_authorized_proxy.py | 4 ++--
tests/authorization/test_provider.py | 4 ++--
tests/authorization/test_ranger.py | 8 ++++----
tests/custom_cluster/test_kill_query.py | 4 ++--
6 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/bin/start-impala-cluster.py b/bin/start-impala-cluster.py
index d9576f932..067098ef2 100755
--- a/bin/start-impala-cluster.py
+++ b/bin/start-impala-cluster.py
@@ -509,7 +509,7 @@ def build_catalogd_arg_list(num_catalogd, remap_ports):
args.extend(
["-state_store_2_port={0}".format(state_store_port + 1)])
if options.enable_ranger_authz:
- args.extend(["--server-name=server1", "--ranger_service_type=hive",
+ args.extend(["--server_name=server1", "--ranger_service_type=hive",
"--ranger_app_id=impala", "--authorization_provider=ranger"])
if options.enable_tls:
args.extend(["--hostname=localhost",
@@ -761,7 +761,7 @@ def build_impalad_arg_lists(cluster_size, num_coordinators, use_exclusive_coordi
os.environ["USE_CALCITE_PLANNER"] = "true"
if options.enable_ranger_authz:
- args = ("--server-name=server1 --ranger_service_type=hive --ranger_app_id=impala "
+ args = ("--server_name=server1 --ranger_service_type=hive --ranger_app_id=impala "
"--authorization_provider=ranger {args}").format(args=args)
if options.enable_tls:
diff --git a/tests/authorization/test_authorization.py b/tests/authorization/test_authorization.py
index 3c8ce1e00..26d147029 100644
--- a/tests/authorization/test_authorization.py
+++ b/tests/authorization/test_authorization.py
@@ -49,10 +49,10 @@ class TestAuthorization(CustomClusterTestSuite):
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(
- impalad_args="--server-name=server1 --ranger_service_type=hive "
+ impalad_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger "
"--min_privilege_set_for_show_stmts=select",
- catalogd_args="--server-name=server1 --ranger_service_type=hive "
+ catalogd_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger")
def test_ranger_show_iceberg_metadata_tables(self, unique_name):
unique_db = unique_name + "_db"
@@ -139,49 +139,49 @@ class TestAuthorization(CustomClusterTestSuite):
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(
- impalad_args="--server-name=server1 --ranger_service_type=hive "
+ impalad_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger "
"--min_privilege_set_for_show_stmts=select",
- catalogd_args="--server-name=server1 --ranger_service_type=hive "
+ catalogd_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger")
def test_ranger_show_stmts_with_select(self, unique_name):
self._test_ranger_show_stmts_helper(unique_name, ['select'])
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(
- impalad_args="--server-name=server1 --ranger_service_type=hive "
+ impalad_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger "
"--min_privilege_set_for_show_stmts=select,insert",
- catalogd_args="--server-name=server1 --ranger_service_type=hive "
+ catalogd_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger")
def test_ranger_show_stmts_with_select_insert(self, unique_name):
self._test_ranger_show_stmts_helper(unique_name, ['select', 'insert'])
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(
- impalad_args="--server-name=server1 --ranger_service_type=hive "
+ impalad_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger "
"--min_privilege_set_for_show_stmts=any",
- catalogd_args="--server-name=server1 --ranger_service_type=hive "
+ catalogd_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger")
def test_ranger_show_stmts_with_any(self, unique_name):
self._test_ranger_show_stmts_helper(unique_name, PRIVILEGES)
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(
- impalad_args="--server-name=server1 --ranger_service_type=hive "
+ impalad_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger "
"--num_check_authorization_threads=%d" % (random.randint(2, 128)),
- catalogd_args="--server-name=server1 --ranger_service_type=hive "
+ catalogd_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger")
def test_num_check_authorization_threads_with_ranger(self, unique_name):
self._test_ranger_show_stmts_helper(unique_name, PRIVILEGES)
@CustomClusterTestSuite.with_args(
- impalad_args="--server-name=server1 --ranger_service_type=hive "
+ impalad_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger "
"--use_local_catalog=true",
- catalogd_args="--server-name=server1 --ranger_service_type=hive "
+ catalogd_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger "
"--catalog_topic_mode=minimal")
def test_local_catalog_show_dbs_with_transient_db(self, unique_name):
diff --git a/tests/authorization/test_authorized_proxy.py b/tests/authorization/test_authorized_proxy.py
index 22654f9b0..8b60972c4 100644
--- a/tests/authorization/test_authorized_proxy.py
+++ b/tests/authorization/test_authorized_proxy.py
@@ -31,13 +31,13 @@ from tests.hs2.hs2_test_suite import operation_id_to_query_id
AUDIT_LOG_DIR = 'audit_log_dir'
-RANGER_IMPALAD_ARGS = ("--server-name=server1 "
+RANGER_IMPALAD_ARGS = ("--server_name=server1 "
"--ranger_service_type=hive "
"--ranger_app_id=impala "
"--authorization_provider=ranger "
"--abort_on_failed_audit_event=false "
"--audit_event_log_dir={" + AUDIT_LOG_DIR + "}")
-RANGER_CATALOGD_ARGS = ("--server-name=server1 "
+RANGER_CATALOGD_ARGS = ("--server_name=server1 "
"--ranger_service_type=hive "
"--ranger_app_id=impala "
"--authorization_provider=ranger")
diff --git a/tests/authorization/test_provider.py b/tests/authorization/test_provider.py
index a15f7ab9a..cc05c0e3d 100644
--- a/tests/authorization/test_provider.py
+++ b/tests/authorization/test_provider.py
@@ -43,12 +43,12 @@ class TestAuthorizationProvider(CustomClusterTestSuite):
expect_cores=True,
impala_log_dir="{" + LOG_DIR + "}",
impalad_args="--minidump_path={" + MINIDUMP_PATH + "} "
- "--server-name=server1 "
+ "--server_name=server1 "
"--ranger_service_type=hive "
"--ranger_app_id=impala "
"--authorization_provider=" + BAD_FLAG,
catalogd_args="--minidump_path={" + MINIDUMP_PATH + "} "
- "--server-name=server1 "
+ "--server_name=server1 "
"--ranger_service_type=hive "
"--ranger_app_id=impala "
"--authorization_provider=" + BAD_FLAG,
diff --git a/tests/authorization/test_ranger.py b/tests/authorization/test_ranger.py
index 521e223dd..8e9f502be 100644
--- a/tests/authorization/test_ranger.py
+++ b/tests/authorization/test_ranger.py
@@ -54,16 +54,16 @@ ERROR_REVOKE = "User doesn't have necessary permission to revoke access"
RANGER_AUTH = ("admin", "admin")
RANGER_HOST = "http://localhost:6080"
REST_HEADERS = {"Content-Type": "application/json", "Accept": "application/json"}
-LEGACY_CATALOG_IMPALAD_ARGS = "--server-name=server1 --ranger_service_type=hive " \
+LEGACY_CATALOG_IMPALAD_ARGS = "--server_name=server1 --ranger_service_type=hive " \
"--ranger_app_id=impala --authorization_provider=ranger " \
"--use_local_catalog=false"
-LEGACY_CATALOG_CATALOGD_ARGS = "--server-name=server1 --ranger_service_type=hive " \
+LEGACY_CATALOG_CATALOGD_ARGS = "--server_name=server1 --ranger_service_type=hive " \
"--ranger_app_id=impala --authorization_provider=ranger " \
"--catalog_topic_mode=full"
-IMPALAD_ARGS = "--server-name=server1 --ranger_service_type=hive " \
+IMPALAD_ARGS = "--server_name=server1 --ranger_service_type=hive " \
"--ranger_app_id=impala --authorization_provider=ranger --use_local_catalog=true"
-CATALOGD_ARGS = "--server-name=server1 --ranger_service_type=hive " \
+CATALOGD_ARGS = "--server_name=server1 --ranger_service_type=hive " \
"--ranger_app_id=impala --authorization_provider=ranger --catalog_topic_mode=minimal"
LOG = logging.getLogger('impala_test_suite')
diff --git a/tests/custom_cluster/test_kill_query.py b/tests/custom_cluster/test_kill_query.py
index f40adb6a9..4f99bc581 100644
--- a/tests/custom_cluster/test_kill_query.py
+++ b/tests/custom_cluster/test_kill_query.py
@@ -116,10 +116,10 @@ class TestKillQuery(CustomClusterTestSuite):
@CustomClusterTestSuite.with_args(
# Same as IMPALAD_ARGS and CATALOGD_ARGS in tests/authorization/test_ranger.py
- impalad_args="--server-name=server1 --ranger_service_type=hive "
+ impalad_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger "
"--beeswax_port=21000",
- catalogd_args="--server-name=server1 --ranger_service_type=hive "
+ catalogd_args="--server_name=server1 --ranger_service_type=hive "
"--ranger_app_id=impala --authorization_provider=ranger",
cluster_size=1)
class TestKillQueryAuthorization(CustomClusterTestSuite):