You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "ttttttz (Code Review)" <ge...@cloudera.org> on 2022/06/22 04:38:21 UTC

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

ttttttz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18652


Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................

IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to "Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan".
It doesn't apply to non-Iceberg and non-FullAcid tables. We should
allow read missing slots for non-Iceberg and non-FullAcid tables.

Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/hdfs-orc-scanner.h
M be/src/exec/orc-column-readers.cc
3 files changed, 9 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#7).

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................

IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to "Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan".
It doesn't apply to non-Iceberg and non-FullAcid tables. We should
allow read missing slots for non-Iceberg and non-FullAcid tables.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M be/src/exec/orc-column-readers.h
M tests/query_test/test_scanners.py
3 files changed, 49 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#19).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 61 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/19
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 19
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 20:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8296/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 20
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 02:16:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 19:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10937/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 19
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 02:32:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 9:

> Patch Set 9:
> 
> (1 comment)

Hi, Quanlong and Zoltan Borok-Nagy! I'm thinking about lifting the constraint on X. Do you think that's a good idea?


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 07:47:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has abandoned this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 07:18:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10833/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 06:32:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#3).

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................

IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to "Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan".
It doesn't apply to non-Iceberg and non-FullAcid tables. We should
allow read missing slots for non-Iceberg and non-FullAcid tables.

Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/hdfs-orc-scanner.h
M be/src/exec/orc-column-readers.cc
3 files changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 16:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10928/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 15:58:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#17).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 47 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/17
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 1:

Quanlong, please help me review it. Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 04:46:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has restored this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Restored
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#6).

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................

IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to "Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan".
It doesn't apply to non-Iceberg and non-FullAcid tables. We should
allow read missing slots for non-Iceberg and non-FullAcid tables.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M tests/query_test/test_scanners.py
1 file changed, 28 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 6
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10842/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 6
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 09:17:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#12).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 44 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/12
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 12:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10915/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 02 Jul 2022 10:08:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/12/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/18652/12/tests/query_test/test_scanners.py@1779
PS12, Line 1779:     assert result.data == ['NULL']
It's unclear to me why the result is just one row of 'NULL'. Shouldn't the result be [1, 'NULL'] (in random order)? Note that at line 1776 we insert the second row.



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 04 Jul 2022 07:56:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc
File be/src/exec/orc-column-readers.cc:

http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc@457
PS9, Line 457:       valid_empty_children_ = scanner_->acid_original_file_ ||
> It seems if children_ is empty, all the slots are either partition slot or 
+1 on completely removing this check. For Iceberg tables users can also add new columns, then query only the new columns.



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 13:30:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 9:

> Patch Set 9:
> 
> > Patch Set 9:
> > 
> > (1 comment)
> 
> Hi, Quanlong and Zoltan Borok-Nagy! I'm thinking about lifting the constraint on FullAcid tables. Do you think that's a good idea?


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 07:48:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 12:

> Patch Set 12:
> 
> (1 comment)

Sorry, it's an oversight.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 04 Jul 2022 08:09:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#14).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 56 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/14
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 14
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#16).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 59 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/16
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 13:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10917/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 13
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 04 Jul 2022 10:24:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10832/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 05:19:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 9: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 26 Jun 2022 06:27:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/7/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/18652/7/tests/query_test/test_scanners.py@1767
PS7, Line 1767: c
flake8: E501 line too long (101 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 09:00:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 8: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/8/be/src/exec/orc-column-readers.cc
File be/src/exec/orc-column-readers.cc:

http://gerrit.cloudera.org:8080/#/c/18652/8/be/src/exec/orc-column-readers.cc@453
PS8, Line 453:     // vector batch (the write id batch).
Please comment the last case, i.e. we allow empty 'children_' if all required fields are missing in the files, and the table is non-ACID and non-Iceberg table.



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 24 Jun 2022 03:10:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 16:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/16/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/18652/16/tests/query_test/test_scanners.py@1787
PS16, Line 1787:     self.run_stmt_in_hive("insert into %s values(0)" % orc_tbl_name)
Ah, I think the Hive we are using in the minicluster test environment is not able to write Iceberg tables. Sorry about that.

Could you please comment out these lines and add a TODO comment that mentions IMPALA-10542? Thanks.



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 10:39:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/12/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/18652/12/tests/query_test/test_scanners.py@1790
PS12, Line 1790:     assert "6001215" in result.data
Could you please add another test that uses an Iceberg table?



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 04 Jul 2022 09:54:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#8).

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................

IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to "Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan".
It doesn't apply to non-Iceberg and non-FullAcid tables. We should
allow read missing slots for non-Iceberg and non-FullAcid tables.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M be/src/exec/orc-column-readers.h
M tests/query_test/test_scanners.py
3 files changed, 50 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#9).

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................

IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to "Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan".
It doesn't apply to non-Iceberg and non-FullAcid tables. We should
allow read missing slots for non-Iceberg and non-FullAcid tables.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M be/src/exec/orc-column-readers.h
M tests/query_test/test_scanners.py
3 files changed, 52 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/10831/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 05:10:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/hdfs-orc-scanner.cc
File be/src/exec/hdfs-orc-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/hdfs-orc-scanner.cc@406
PS5, Line 406:       (!scan_node_->hdfs_table()->IsIcebergTable() &&
             :           !scan_node_->hdfs_table()->IsTableFullAcid()
> This allows empty children for all non-iceberg non-full acid tables.
+1 on this. Maybe we can move this field into the OrcColumnReaders. In the readers, we match the table schema with the file schema and check missing fields there.



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 02:50:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> Thanks for fixing this! The fix LGTM. Could you add some tests like what you did in https://gerrit.cloudera.org/c/18571/9/tests/query_test/test_scanners.py ?

OK! Please wait a moment.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 06:00:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/4/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/18652/4/tests/query_test/test_scanners.py@1753
PS4, Line 1753:   @SkipIfS3.hive
We need other skip annotations as well:

  @SkipIfGCS.hive
  @SkipIfCOS.hive



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 06:48:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 5:

> Patch Set 4:
> 
> (1 comment)

It has been fixed.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 07:14:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#2).

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................

IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to "Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan".
It doesn't apply to non-Iceberg and non-FullAcid tables. We should
allow read missing slots for non-Iceberg and non-FullAcid tables.

Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/hdfs-orc-scanner.h
M be/src/exec/orc-column-readers.cc
A cmake-build-debug/.cmake/api/v1/query/cache-v2
A cmake-build-debug/.cmake/api/v1/query/cmakeFiles-v1
A cmake-build-debug/.cmake/api/v1/query/codemodel-v2
A cmake-build-debug/.cmake/api/v1/query/toolchains-v1
7 files changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 9:

> Patch Set 8: Code-Review+1
> 
> (1 comment)
I have finished it, thanks Quanlong!


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 24 Jun 2022 03:37:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10911/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 10
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 02 Jul 2022 03:33:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 11:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10914/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 11
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 02 Jul 2022 10:05:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/14/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/18652/14/tests/query_test/test_scanners.py@1783
PS14, Line 1783: i
flake8: E501 line too long (114 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 14
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 14:03:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 15:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10925/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 15
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 14:28:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 17:

> Patch Set 16:
> 
> (1 comment)

OK!


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 12:32:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 17:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10934/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 12:53:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 16:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/16/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/18652/16/tests/query_test/test_scanners.py@1785
PS16, Line 1785: stored as iceberg stored as orc
I don't think this is the right syntax. You can run the test locally by

 impala-py.test tests/query_test/test_scanners.py::TestOrc::test_missing_field_orc

Refer to https://impala.apache.org/docs/build/html/topics/impala_iceberg.html
The statement should be something like

 create table ice_orc (f0 int) stored as iceberg tblproperties('write.format.default' = 'orc');



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 10:10:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 9: -Code-Review

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc
File be/src/exec/orc-column-readers.cc:

http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc@457
PS9, Line 457:       valid_empty_children_ = scanner_->acid_original_file_ ||
> I think we should allow empty children whenever we only scan partition slot
It seems if children_ is empty, all the slots are either partition slot or missing field slot or virtual slot, because we always add a child in CreateChildForSlot() at line 447.

Should we allow all cases except iceberg tables? I'm also not sure what iceberg cases we should throw ParseError. Maybe we can just skip this valid_empty_children_ check.



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 13:02:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#11).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 35 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/11
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 11
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#15).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 57 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/15
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 15
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 15:

> Patch Set 12:
> 
> (1 comment)

OK! I have recommitted the latest code.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 15
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 14:46:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 16: Code-Review+1

Thanks for fixing this!


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 15:44:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 4:

> Patch Set 4:
> 
> (1 comment)

Ok, thanks Quanlong. It is necessary to take some time later to confirm the meaning of these annotations.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 07:06:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/10830/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 04:47:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 5:

(2 comments)

Thanks for working on this fix.

http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/hdfs-orc-scanner.cc
File be/src/exec/hdfs-orc-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/hdfs-orc-scanner.cc@406
PS5, Line 406:       (!scan_node_->hdfs_table()->IsIcebergTable() &&
             :           !scan_node_->hdfs_table()->IsTableFullAcid()
This allows empty children for all non-iceberg non-full acid tables.

Instead of this, can we only allow empty children when there are missing fields? Or only if all selected fields are missing?


http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/orc-column-readers.cc
File be/src/exec/orc-column-readers.cc:

http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/orc-column-readers.cc@534
PS5, Line 534:     // We allow empty 'children_' for original files, because we might select the
             :     // synthetic 'rowid' field which is not present in original files.
             :     // We also allow empty 'children_' when we need to validate row batches of a zero slot
             :     // scan. In that case 'children_' is empty and only 'row_validator_' owns an ORC
             :     // vector batch (the write id batch).
Can we move this comment to the declaration of 'valid_empty_children_'?



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 09:22:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 5:

> Patch Set 5:
> 
> (2 comments)
> 
> Thanks for working on this fix.

I agree with you. I consider moving this comment to the assignment of 'valid_empty_children_'.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 02:18:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#13).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 45 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/13
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 13
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Reviewed-on: http://gerrit.cloudera.org:8080/18652
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 61 insertions(+), 22 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 21
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10861/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 24 Jun 2022 03:50:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10844/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 09:22:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc
File be/src/exec/orc-column-readers.cc:

http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc@457
PS9, Line 457:       valid_empty_children_ = scanner_->acid_original_file_ ||
I think we should allow empty children whenever we only scan partition slots and/or all slots are missing in the file.

E.g. we still get an error in the following case:

 In Hive>
 create table full_txn_test (i int) stored as orc tblproperties ('transactional'='true');
 insert into full_txn_test values (3);
 alter table full_txn_test add columns (j int);
 insert into full_txn_test values (1,2);
 select j from full_txn_test;
 +-------+
 |   j   |
 +-------+
 | NULL  |
 | 2     |
 +-------+


 In Impala>
 select j from full_txn_test;
 ERROR: Parse error in possibly corrupt ORC file: 'hdfs://localhost:20500/test-warehouse/managed/full_txn_test/delta_0000001_0000001_0000/bucket_00000_0'. No columns found for this scan.



-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 9
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 28 Jun 2022 09:31:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#10).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 35 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/10
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 10
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10834/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 07:31:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#5).

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................

IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to "Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan".
It doesn't apply to non-Iceberg and non-FullAcid tables. We should
allow read missing slots for non-Iceberg and non-FullAcid tables.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/hdfs-orc-scanner.h
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
4 files changed, 37 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 20: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 20
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 02:16:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#18).

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................

IMPALA-11344: Missing slots in all cases should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to `Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan`.
We should allow read missing slots in all cases.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
2 files changed, 48 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/18
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 18
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10843/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 09:19:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has restored this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Restored
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 3:

Thanks for fixing this! The fix LGTM. Could you add some tests like what you did in https://gerrit.cloudera.org/c/18571/9/tests/query_test/test_scanners.py ?


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 05:57:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18652

to look at the new patch set (#4).

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................

IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

When selecting only the missing fields of ORC files and the missing fields
contain non-partition fields, the query will fail due to "Parse error in
possibly corrupt ORC file: '$filename'. No columns found for this scan".
It doesn't apply to non-Iceberg and non-FullAcid tables. We should
allow read missing slots for non-Iceberg and non-FullAcid tables.

Testing:
- Added a test to test_scanners.py that ensures the query can be
  executed successfully when selecting only the missing fields of
  ORC files.
Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
---
M be/src/exec/hdfs-orc-scanner.cc
M be/src/exec/hdfs-orc-scanner.h
M be/src/exec/orc-column-readers.cc
M tests/query_test/test_scanners.py
4 files changed, 35 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/18652/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 4:

> Patch Set 3:
> 
> Thanks for fixing this! The fix LGTM. Could you add some tests like what you did in https://gerrit.cloudera.org/c/18571/9/tests/query_test/test_scanners.py ?

Hi Quanlong, I have added relevant test cases. Please confirm it.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 06:21:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Patch Set 8:

> Patch Set 5:
> 
> (1 comment)

Yes, it's better to avoid triggering bugs during later adjustments.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 24 Jun 2022 01:59:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has abandoned this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 19: Code-Review+2

Carry Zoltan's +1 since there are only changes on comments. Thanks for making this fixed!


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 19
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 02:15:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 18:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10936/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 18
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 02:22:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 14:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10924/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 14
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 14:23:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )

Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read
......................................................................


Patch Set 20: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023
Gerrit-Change-Number: 18652
Gerrit-PatchSet: 20
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 07:05:28 +0000
Gerrit-HasComments: No