You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "l81893521 (via GitHub)" <gi...@apache.org> on 2024/08/21 15:03:01 UTC
[PR] test: update Codecov live icon [incubator-seata]
l81893521 opened a new pull request, #6773:
URL: https://github.com/apache/incubator-seata/pull/6773
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
Update the Codecov live icon
### Ⅱ. Does this pull request fix one issue?
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: update Codecov live icon [incubator-seata]
Posted by "l81893521 (via GitHub)" <gi...@apache.org>.
l81893521 commented on code in PR #6773:
URL: https://github.com/apache/incubator-seata/pull/6773#discussion_r1729178647
##########
changes/en-us/2.x.md:
##########
@@ -72,6 +72,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6647](https://github.com/apache/incubator-seata/pull/6647)] improve the test case coverage of saga module to 70%
- [[#6695](https://github.com/apache/incubator-seata/pull/6695)] old version(< 0.7.1) client test case for multi-version protocol
- [[#6750](https://github.com/apache/incubator-seata/pull/6750)] increase spring autoconfigure module unit test converage
+- [[#6773](https://github.com/apache/incubator-seata/pull/6773)] update the codecov live icon
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: update Codecov live icon [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6773:
URL: https://github.com/apache/incubator-seata/pull/6773#discussion_r1726714246
##########
changes/en-us/2.x.md:
##########
@@ -72,6 +72,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6647](https://github.com/apache/incubator-seata/pull/6647)] improve the test case coverage of saga module to 70%
- [[#6695](https://github.com/apache/incubator-seata/pull/6695)] old version(< 0.7.1) client test case for multi-version protocol
- [[#6750](https://github.com/apache/incubator-seata/pull/6750)] increase spring autoconfigure module unit test converage
+- [[#6773](https://github.com/apache/incubator-seata/pull/6773)] update the codecov live icon
Review Comment:
应该是将codecov覆盖率显示为default分支的改动，而不是更新icon
It should show codecov coverage as a change to the default branch, not an update icon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: update Codecov live icon [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #6773:
URL: https://github.com/apache/incubator-seata/pull/6773#issuecomment-2302350327
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6773?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 52.18%. Comparing base [(`79a6744`)](https://app.codecov.io/gh/apache/incubator-seata/commit/79a6744cf3d8e635e079e88a6ca2d1fb2678316a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3fce795`)](https://app.codecov.io/gh/apache/incubator-seata/commit/3fce7954f98c85ee07b756c8f1e6361a84fdcbdd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6773 +/- ##
=========================================
Coverage 52.17% 52.18%
- Complexity 6288 6289 +1
=========================================
Files 1063 1063
Lines 37153 37153
Branches 4408 4406 -2
=========================================
+ Hits 19385 19388 +3
+ Misses 15856 15853 -3
Partials 1912 1912
```
[see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6773/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: fix the wrong code coverage from codecov icon in default branch [incubator-seata]
Posted by "l81893521 (via GitHub)" <gi...@apache.org>.
l81893521 merged PR #6773:
URL: https://github.com/apache/incubator-seata/pull/6773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org