You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by kkhatua <gi...@git.apache.org> on 2018/02/06 00:39:43 UTC

[GitHub] drill pull request #1082: DRILL-5741: Automatically manage memory allocation...

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1082#discussion_r166157369
  
    --- Diff: distribution/src/assemble/bin.xml ---
    @@ -345,6 +345,21 @@
           <fileMode>0755</fileMode>
           <outputDirectory>conf</outputDirectory>
         </file>
    +    <file>
    +      <source>src/resources/auto-setup.sh</source>
    +      <fileMode>0755</fileMode>
    +      <outputDirectory>bin</outputDirectory>
    +    </file>
    +    <file>
    +      <source>src/resources/drill-setup.sh</source>
    +      <fileMode>0755</fileMode>
    +      <outputDirectory>conf</outputDirectory>
    +    </file>
    +    <file>
    +      <source>src/resources/distrib-setup.sh</source>
    --- End diff --
    
    The `distrib-setup.sh` file is empty, but provided the placeholder to indicate where distributions should make the change.
    This is identical to the intent of having `distrib-env.sh` in the Apache distribution, which is also empty but serves the same purpose.
    https://github.com/apache/drill/blob/master/distribution/src/resources/distrib-env.sh
    Just following the same convention.


---