You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by rf...@apache.org on 2007/10/23 21:04:04 UTC
svn commit: r587614 - in
/lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site:
tree/TreeSiteManager.java tree2/TreeSiteManager.java
Author: rfrovarp
Date: Tue Oct 23 12:04:03 2007
New Revision: 587614
URL: http://svn.apache.org/viewvc?rev=587614&view=rev
Log:
Comment added to clear up my confusion as to the return results.
Modified:
lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree/TreeSiteManager.java
lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree2/TreeSiteManager.java
Modified: lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree/TreeSiteManager.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree/TreeSiteManager.java?rev=587614&r1=587613&r2=587614&view=diff
==============================================================================
--- lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree/TreeSiteManager.java (original)
+++ lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree/TreeSiteManager.java Tue Oct 23 12:04:03 2007
@@ -323,6 +323,7 @@
SiteTreeNode node;
if (!tree.contains(path)) {
+ // done for side effect of calling addNodNode, not the resulting return value
node = tree.addNode(path, document.getUUID(), true, null, null, false);
} else {
node = (SiteTreeNode) tree.getNode(path);
Modified: lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree2/TreeSiteManager.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree2/TreeSiteManager.java?rev=587614&r1=587613&r2=587614&view=diff
==============================================================================
--- lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree2/TreeSiteManager.java (original)
+++ lenya/trunk/src/modules/sitetree/java/src/org/apache/lenya/cms/site/tree2/TreeSiteManager.java Tue Oct 23 12:04:03 2007
@@ -125,8 +125,10 @@
SiteNode destNode = destinationTree.getNode(destPath);
if (destNode == null) {
if (siblingPath == null) {
+ // called for side effect of add, not return result
destNode = destinationTree.add(destPath);
} else {
+ // called for side effect of add, not return result
destNode = destinationTree.add(destPath, siblingPath);
}
destinationTree.add(destPath, destDoc);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org