You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/07/12 14:56:21 UTC

[jira] [Commented] (AIRFLOW-228) PR tool should be friendly about bad JIRA versions

    [ https://issues.apache.org/jira/browse/AIRFLOW-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372996#comment-15372996 ] 

ASF subversion and git services commented on AIRFLOW-228:
---------------------------------------------------------

Commit 8f863d7ea7908da0cab417d16f0634d7ec8bf29a in incubator-airflow's branch refs/heads/master from jlowin
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=8f863d7 ]

[AIRFLOW-228] Handle empty version list in PR tool

If the filter matched no version names, it would return an empty list
and the [0] index would fail.


> PR tool should be friendly about bad JIRA versions
> --------------------------------------------------
>
>                 Key: AIRFLOW-228
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-228
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: PR tool
>    Affects Versions: Airflow 1.7.1.2
>            Reporter: Chris Riccomini
>
> When running the PR tool, I entered 1.8 as the version, and got:
> {noformat}
> Proceed with AIRFLOW-AIRFLOW-142? [y/N]: y
> Enter comma-separated fix version(s) []: 1.8
> Resetting git to remove any changes
> >> Running command: git reset --hard
> Restoring head pointer to master
> >> Running command: git checkout master
> Already on 'master'
> >> Running command: git branch
> Traceback (most recent call last):
>   File "dev/airflow-pr", line 892, in <module>
>     cli()
>   File "/Users/chrisr/.virtual-env/airflow/lib/python2.7/site-packages/click/core.py", line 716, in __call__
>     return self.main(*args, **kwargs)
>   File "/Users/chrisr/.virtual-env/airflow/lib/python2.7/site-packages/click/core.py", line 696, in main
>     rv = self.invoke(ctx)
>   File "/Users/chrisr/.virtual-env/airflow/lib/python2.7/site-packages/click/core.py", line 1060, in invoke
>     return _process_result(sub_ctx.command.invoke(sub_ctx))
>   File "/Users/chrisr/.virtual-env/airflow/lib/python2.7/site-packages/click/core.py", line 889, in invoke
>     return ctx.invoke(self.callback, **ctx.params)
>   File "/Users/chrisr/.virtual-env/airflow/lib/python2.7/site-packages/click/core.py", line 534, in invoke
>     return callback(*args, **kwargs)
>   File "dev/airflow-pr", line 830, in merge
>     main(pr_num, local=False)
>   File "dev/airflow-pr", line 763, in main
>     merge_branches=merged_refs)
>   File "dev/airflow-pr", line 534, in resolve_jira_issue
>     map(lambda v: get_version_json(v), fix_versions))
>   File "dev/airflow-pr", line 534, in <lambda>
>     map(lambda v: get_version_json(v), fix_versions))
>   File "dev/airflow-pr", line 530, in get_version_json
>     return list(filter(lambda v: v.name == version_str, versions))[0].raw
> IndexError: list index out of range
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)