You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Mingliang Liu (JIRA)" <ji...@apache.org> on 2016/08/29 18:23:20 UTC
[jira] [Commented] (HADOOP-13559) Remove close() within
try-with-resources
[ https://issues.apache.org/jira/browse/HADOOP-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446648#comment-15446648 ]
Mingliang Liu commented on HADOOP-13559:
----------------------------------------
Nice catch! +1 pending on Jenkins.
> Remove close() within try-with-resources
> ----------------------------------------
>
> Key: HADOOP-13559
> URL: https://issues.apache.org/jira/browse/HADOOP-13559
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.8.0, 2.9.0
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Priority: Minor
> Attachments: HADOOP-13559-001.patch
>
>
> My colleague noticed that HADOOP-12994 introduced to places where close() was still called manually within a try-with-resources block.
> I'll attach a patch to remove the manual close() calls.
> These extra calls to close() are probably safe, as InputStream is a Closable, not AutoClosable (the later does not specify close() as idempotent).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org