You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/04/10 20:40:01 UTC

Review Request 58321: Added a new overload of 'StartSlave'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58321/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description
-------

This patch adds a new overload of the `StartSlave` test helper
which accepts just a `MasterDetector`, an ID, and flags.


Diffs
-----

  src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2 
  src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59 


Diff: https://reviews.apache.org/r/58321/diff/1/


Testing
-------

Testing details can be found in the following patch in this chain.


Thanks,

Greg Mann

Re: Review Request 58321: Added a new overload of 'StartSlave'.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58321/#review171617
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On April 10, 2017, 8:40 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58321/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 8:40 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new overload of the `StartSlave` test helper
> which accepts just a `MasterDetector`, an ID, and flags.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2 
>   src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59 
> 
> 
> Diff: https://reviews.apache.org/r/58321/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details can be found in the following patch in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>