[GitHub] [solr] mkhludnev edited a comment on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

[GitBox <gi...@apache.org>]

mkhludnev edited a comment on pull request #376:
URL: https://github.com/apache/solr/pull/376#issuecomment-959942709


   @madrob, honestly, I hardly follow.  
   > we don't want to change things to strict. .. then we log it and ask the person to create an issue
   
   we do logging when refcount==-1, but when refcount==0 it's regular closing, and core should be closed even with no WARN log. And that's what happen here when `/export?q={!join}`, and btw and user can close almost any core of reachable instance. 
   I'm not sure what you mean in usages of `SRI.getInheritableThreadLocalProvider().clean()`. I still think this `clean()` shouldn't close SRI, but just clean pool's threadlocal. I have an idea how to test it. But I don't know how to distinguish between old and potentially new test failures if I commit it. Does it sounds like an idea for the third attempt?  
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org