You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/08/22 17:17:03 UTC
[GitHub] [guacamole-client] mike-jumper opened a new pull request, #757: GUACAMOLE-1614: Include chromium-driver in Docker build for sake of JS unit tests.
mike-jumper opened a new pull request, #757:
URL: https://github.com/apache/guacamole-client/pull/757
This change corrects the Docker build failures noted on https://issues.apache.org/jira/browse/GUACAMOLE-1614, which are ultimately due to the Jasmine Maven plugin requiring chromium-driver to run its tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #757: GUACAMOLE-1614: Include chromium-driver in Docker build for sake of JS unit tests.
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on code in PR #757:
URL: https://github.com/apache/guacamole-client/pull/757#discussion_r951703138
##########
Dockerfile:
##########
@@ -30,6 +30,9 @@ ARG TOMCAT_JRE=jdk8
# Use official maven image for the build
FROM maven:3-jdk-8 AS builder
+# Install chromium-driver for sake of JavaScript unit tests
+RUN apt update && apt install -y chromium-driver
Review Comment:
We're already apt-updating on line 57 below - do we need to do it twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #757: GUACAMOLE-1614: Include chromium-driver in Docker build for sake of JS unit tests.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on code in PR #757:
URL: https://github.com/apache/guacamole-client/pull/757#discussion_r951779280
##########
Dockerfile:
##########
@@ -30,6 +30,9 @@ ARG TOMCAT_JRE=jdk8
# Use official maven image for the build
FROM maven:3-jdk-8 AS builder
+# Install chromium-driver for sake of JavaScript unit tests
+RUN apt update && apt install -y chromium-driver
Review Comment:
> We're already apt-updating on line 57 below - do we need to do it twice?
Yes - this is for the build image of a multi-stage build, whereas line 57 is the runtime image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #757: GUACAMOLE-1614: Include chromium-driver in Docker build for sake of JS unit tests.
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on code in PR #757:
URL: https://github.com/apache/guacamole-client/pull/757#discussion_r951754873
##########
Dockerfile:
##########
@@ -30,6 +30,9 @@ ARG TOMCAT_JRE=jdk8
# Use official maven image for the build
FROM maven:3-jdk-8 AS builder
+# Install chromium-driver for sake of JavaScript unit tests
+RUN apt update && apt install -y chromium-driver
Review Comment:
Good point @necouchman - should probably be `apt-get`. `apt` is specifically discouraged from being used in scripts by the developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a diff in pull request #757: GUACAMOLE-1614: Include chromium-driver in Docker build for sake of JS unit tests.
Posted by GitBox <gi...@apache.org>.
necouchman commented on code in PR #757:
URL: https://github.com/apache/guacamole-client/pull/757#discussion_r951748389
##########
Dockerfile:
##########
@@ -30,6 +30,9 @@ ARG TOMCAT_JRE=jdk8
# Use official maven image for the build
FROM maven:3-jdk-8 AS builder
+# Install chromium-driver for sake of JavaScript unit tests
+RUN apt update && apt install -y chromium-driver
Review Comment:
Also, should this be `apt update` and then `apt install`, or `apt-get update` and `apt-get install`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #757: GUACAMOLE-1614: Include chromium-driver in Docker build for sake of JS unit tests.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on code in PR #757:
URL: https://github.com/apache/guacamole-client/pull/757#discussion_r951790929
##########
Dockerfile:
##########
@@ -30,6 +30,9 @@ ARG TOMCAT_JRE=jdk8
# Use official maven image for the build
FROM maven:3-jdk-8 AS builder
+# Install chromium-driver for sake of JavaScript unit tests
+RUN apt update && apt install -y chromium-driver
Review Comment:
OK - amended the commit to use `apt-get`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner merged pull request #757: GUACAMOLE-1614: Include chromium-driver in Docker build for sake of JS unit tests.
Posted by GitBox <gi...@apache.org>.
jmuehlner merged PR #757:
URL: https://github.com/apache/guacamole-client/pull/757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org