You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/03/06 10:45:15 UTC
[GitHub] [hive] prasanthj opened a new pull request #941: HIVE-22979:
Support total file size in statistics annotation
prasanthj opened a new pull request #941: HIVE-22979: Support total file size in statistics annotation
URL: https://github.com/apache/hive/pull/941
Hive statistics annotation provide estimated Statistics for each operator. The data size provided in TableScanOperator is raw data size (after decompression and decoding), but there are some optimizations that can be performed based on total file size on disk (scan cost estimation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] prasanthj commented on a change in pull request #941:
HIVE-22979: Support total file size in statistics annotation
Posted by GitBox <gi...@apache.org>.
prasanthj commented on a change in pull request #941: HIVE-22979: Support total file size in statistics annotation
URL: https://github.com/apache/hive/pull/941#discussion_r389048647
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java
##########
@@ -53,19 +53,21 @@ public State merge(State otherState) {
private long numRows;
private long runTimeNumRows;
private long dataSize;
+ private long totalFileSize;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #941:
HIVE-22979: Support total file size in statistics annotation
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #941: HIVE-22979: Support total file size in statistics annotation
URL: https://github.com/apache/hive/pull/941#discussion_r389043859
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java
##########
@@ -53,19 +53,21 @@ public State merge(State otherState) {
private long numRows;
private long runTimeNumRows;
private long dataSize;
+ private long totalFileSize;
Review comment:
Could you add a comment on what dataSize and totalFileSize mean? It will prevent us from getting confused when we check the code back after some time :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #941:
HIVE-22979: Support total file size in statistics annotation
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #941: HIVE-22979: Support total file size in statistics annotation
URL: https://github.com/apache/hive/pull/941#discussion_r389044259
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
##########
@@ -147,7 +147,7 @@
* - hive configuration
* @param partList
* - partition list
- * @param table
+ * @param tablebasicStats.getNumRows()
Review comment:
Unintended change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] prasanthj commented on a change in pull request #941:
HIVE-22979: Support total file size in statistics annotation
Posted by GitBox <gi...@apache.org>.
prasanthj commented on a change in pull request #941: HIVE-22979: Support total file size in statistics annotation
URL: https://github.com/apache/hive/pull/941#discussion_r389048770
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
##########
@@ -147,7 +147,7 @@
* - hive configuration
* @param partList
* - partition list
- * @param table
+ * @param tablebasicStats.getNumRows()
Review comment:
Yup. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org