You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/02/28 22:12:46 UTC
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18281
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
[tablet] don't call UpdateMetricsForOp() for rows with errors
This patch updates the control path in WriteOp::UpdatePerRowErrors()
to avoid calling UpdateMetricsForOp() for a row that contains an error
since that's effectively a no-op.
Also, renamed UpdatePerRowErrors() into UpdatePerRowMetricsAndErrors().
Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
---
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
2 files changed, 16 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/18281/1
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18281 )
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
[tablet] don't call UpdateMetricsForOp() for rows with errors
This patch updates the control path in WriteOp::UpdatePerRowErrors()
to avoid calling UpdateMetricsForOp() for a row that contains an error
since that's effectively a no-op.
Also, renamed UpdatePerRowErrors() into UpdatePerRowMetricsAndErrors().
Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Reviewed-on: http://gerrit.cloudera.org:8080/18281
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
2 files changed, 15 insertions(+), 13 deletions(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18281 )
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
Patch Set 1: Verified+1
unrelated test failure in CatalogManagerConfigurations/MasterStressTest.Test/3
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 28 Feb 2022 23:21:41 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18281
to look at the new patch set (#2).
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
[tablet] don't call UpdateMetricsForOp() for rows with errors
This patch updates the control path in WriteOp::UpdatePerRowErrors()
to avoid calling UpdateMetricsForOp() for a row that contains an error
since that's effectively a no-op.
Also, renamed UpdatePerRowErrors() into UpdatePerRowMetricsAndErrors().
Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
---
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
2 files changed, 15 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/18281/2
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18281 )
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Mar 2022 01:05:19 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18281 )
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18281/1/src/kudu/tablet/ops/write_op.cc
File src/kudu/tablet/ops/write_op.cc:
http://gerrit.cloudera.org:8080/#/c/18281/1/src/kudu/tablet/ops/write_op.cc@250
PS1, Line 250: !op->result->has_failed_status()
nit: maybe put this in an else block to avoid the negative?
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 28 Feb 2022 23:43:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18281 )
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18281/1/src/kudu/tablet/ops/write_op.cc
File src/kudu/tablet/ops/write_op.cc:
http://gerrit.cloudera.org:8080/#/c/18281/1/src/kudu/tablet/ops/write_op.cc@250
PS1, Line 250: !op->result->has_failed_status()
> nit: maybe put this in an else block to avoid the negative?
Good idea! Done.
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Mar 2022 00:14:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18281 )
Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................
Patch Set 2: Verified+1
unrelated test failure in CatalogManagerConfigurations/MasterStressTest.Test/1
--
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Mar 2022 00:56:45 +0000
Gerrit-HasComments: No