You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Giulio Cesare Solaroli (JIRA)" <ji...@apache.org> on 2011/04/05 17:28:05 UTC
[jira] [Created] (DROIDS-139) Error in SimpleTaskQueueWithHistory
Error in SimpleTaskQueueWithHistory
-----------------------------------
Key: DROIDS-139
URL: https://issues.apache.org/jira/browse/DROIDS-139
Project: Droids
Issue Type: Bug
Components: core
Affects Versions: 0.0.1
Reporter: Giulio Cesare Solaroli
Priority: Critical
Attachments: testCase.diff
The SimpleTaskQueueWithHistory class will not accept any new value added with either the 'offer' nor 'add' method, due to a cross check that always fails.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DROIDS-139) Error in SimpleTaskQueueWithHistory
Posted by "Richard Frovarp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016056#comment-13016056 ]
Richard Frovarp commented on DROIDS-139:
----------------------------------------
Thanks for the report and patches. The one issue I see is the fix requires that offer() will call add(). If there is an implementation of LinkedList where offer() does not call add(), the history part will no longer work. I don't know if there is a better method or not.
> Error in SimpleTaskQueueWithHistory
> -----------------------------------
>
> Key: DROIDS-139
> URL: https://issues.apache.org/jira/browse/DROIDS-139
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Giulio Cesare Solaroli
> Priority: Critical
> Attachments: patch.diff, testCase.diff
>
>
> The SimpleTaskQueueWithHistory class will not accept any new value added with either the 'offer' nor 'add' method, due to a cross check that always fails.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DROIDS-139) Error in SimpleTaskQueueWithHistory
Posted by "Richard Frovarp (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Frovarp resolved DROIDS-139.
------------------------------------
Resolution: Fixed
Fix Version/s: 0.0.1
Assignee: Richard Frovarp
Appears that patch is working. Closing old issue.
> Error in SimpleTaskQueueWithHistory
> -----------------------------------
>
> Key: DROIDS-139
> URL: https://issues.apache.org/jira/browse/DROIDS-139
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Giulio Cesare Solaroli
> Assignee: Richard Frovarp
> Priority: Critical
> Fix For: 0.0.1
>
> Attachments: patch.diff, testCase.diff
>
>
> The SimpleTaskQueueWithHistory class will not accept any new value added with either the 'offer' nor 'add' method, due to a cross check that always fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DROIDS-139) Error in SimpleTaskQueueWithHistory
Posted by "Richard Frovarp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016063#comment-13016063 ]
Richard Frovarp commented on DROIDS-139:
----------------------------------------
Fixed in r1089152. I did make it so that offer() will always blindly call add(). This should keep history even if the implementation doesn't call add() from offer(). Does anyone see any problems with this?
> Error in SimpleTaskQueueWithHistory
> -----------------------------------
>
> Key: DROIDS-139
> URL: https://issues.apache.org/jira/browse/DROIDS-139
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Giulio Cesare Solaroli
> Priority: Critical
> Attachments: patch.diff, testCase.diff
>
>
> The SimpleTaskQueueWithHistory class will not accept any new value added with either the 'offer' nor 'add' method, due to a cross check that always fails.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DROIDS-139) Error in SimpleTaskQueueWithHistory
Posted by "Giulio Cesare Solaroli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giulio Cesare Solaroli updated DROIDS-139:
------------------------------------------
Attachment: testCase.diff
Test case showing the problem
> Error in SimpleTaskQueueWithHistory
> -----------------------------------
>
> Key: DROIDS-139
> URL: https://issues.apache.org/jira/browse/DROIDS-139
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Giulio Cesare Solaroli
> Priority: Critical
> Attachments: testCase.diff
>
>
> The SimpleTaskQueueWithHistory class will not accept any new value added with either the 'offer' nor 'add' method, due to a cross check that always fails.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DROIDS-139) Error in SimpleTaskQueueWithHistory
Posted by "Giulio Cesare Solaroli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giulio Cesare Solaroli updated DROIDS-139:
------------------------------------------
Attachment: patch.diff
And this is the patch to fix the problem.
> Error in SimpleTaskQueueWithHistory
> -----------------------------------
>
> Key: DROIDS-139
> URL: https://issues.apache.org/jira/browse/DROIDS-139
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Giulio Cesare Solaroli
> Priority: Critical
> Attachments: patch.diff, testCase.diff
>
>
> The SimpleTaskQueueWithHistory class will not accept any new value added with either the 'offer' nor 'add' method, due to a cross check that always fails.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DROIDS-139) Error in SimpleTaskQueueWithHistory
Posted by "Giulio Cesare Solaroli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016086#comment-13016086 ]
Giulio Cesare Solaroli commented on DROIDS-139:
-----------------------------------------------
Looking at LinkedList JavaDoc, it looks like 'offer' and 'add' have the same semantic. So the current implementation should work fine.
> Error in SimpleTaskQueueWithHistory
> -----------------------------------
>
> Key: DROIDS-139
> URL: https://issues.apache.org/jira/browse/DROIDS-139
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Giulio Cesare Solaroli
> Priority: Critical
> Attachments: patch.diff, testCase.diff
>
>
> The SimpleTaskQueueWithHistory class will not accept any new value added with either the 'offer' nor 'add' method, due to a cross check that always fails.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira