[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on a diff in pull request #334: feat(pitr): agent helath check support schema

["Xu-Wentao (via GitHub)" <gi...@apache.org>]

Xu-Wentao commented on code in PR #334:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/334#discussion_r1184644031


##########
pitr/agent/internal/handler/healthcheck.go:
##########
@@ -38,5 +38,12 @@ func HealthCheck(ctx *fiber.Ctx) error {
 		return fmt.Errorf(efmt, in.Username, len(in.Password), in.DBName, err)
 	}
 
+	// check schema if needed
+	if in.Schema != "" {
+		if err := pkg.OG.CheckSchema(in.Username, in.Password, in.DBName, in.DBPort, in.Schema); err != nil {
+			return fmt.Errorf("pkg.OG.CheckSchema() return err=%s,wrap=%w", err, err)

Review Comment:
   > brackets can be remove in error message
   
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org