You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/01 05:37:10 UTC

[GitHub] [arrow] emkornfield commented on a change in pull request #8648: ARROW-7906: [C++] [Python] Add ORC write support

emkornfield commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r567574092



##########
File path: cpp/src/arrow/adapters/orc/adapter.cc
##########
@@ -77,6 +68,15 @@ namespace orc {
   ORC_ASSIGN_OR_THROW_IMPL(ARROW_ASSIGN_OR_RAISE_NAME(_error_or_value, __COUNTER__), \
                            lhs, rexpr);
 
+const uint64_t ORC_NATURAL_WRITE_SIZE = 128 * 1024;  // Required by liborc::Outstream

Review comment:
       constexpr is even better.  Also style convention for constants is kOrcNaturalWriteSize




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org