You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org> on 2009/01/16 02:44:59 UTC
[jira] Created: (WICKET-2021) When a form is not valid, the
textfields become with "raw input" and can't change its model on subsequent
requests
When a form is not valid, the textfields become with "raw input" and can't change its model on subsequent requests
------------------------------------------------------------------------------------------------------------------
Key: WICKET-2021
URL: https://issues.apache.org/jira/browse/WICKET-2021
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-RC1
Reporter: Adriano dos Santos Fernandes
Quickstart attached. To reproduce:
1) Open the homepage
2) Enter something on the second field and click submit
3) An error is displayed - the first field is required
4) Click changeModel (that doesn't submit the form)
5) The labels update, but the textfields doesn't
Also attached a patch that seems to fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2021) When a form is not valid, the
textfields become with "raw input" and can't change its model on subsequent
requests
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664388#action_12664388 ]
Adriano dos Santos Fernandes commented on WICKET-2021:
------------------------------------------------------
Anyway, I need to ask them. Would not be good to have the raw input be cleared after the render phase?
> When a form is not valid, the textfields become with "raw input" and can't change its model on subsequent requests
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2021
> URL: https://issues.apache.org/jira/browse/WICKET-2021
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.5-M1
>
> Attachments: formvalidationtest.tar.gz, patch.diff
>
>
> Quickstart attached. To reproduce:
> 1) Open the homepage
> 2) Enter something on the second field and click submit
> 3) An error is displayed - the first field is required
> 4) Click changeModel (that doesn't submit the form)
> 5) The labels update, but the textfields doesn't
> Also attached a patch that seems to fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2021) When a form is not valid, the
textfields become with "raw input" and can't change its model on subsequent
requests
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664377#action_12664377 ]
Adriano dos Santos Fernandes commented on WICKET-2021:
------------------------------------------------------
> if we apply your patch then all invalid components would always lose their input and be redrawn blank, obviously not something we want.
Why? Did you run my test?
Note, onError calls target.addComponent(form) and the values are not lost. From my understanding (as the component user), the raw values should be maintained when rendering the component, but not on subsequent requests.
> When a form is not valid, the textfields become with "raw input" and can't change its model on subsequent requests
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2021
> URL: https://issues.apache.org/jira/browse/WICKET-2021
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.5-M1
>
> Attachments: formvalidationtest.tar.gz, patch.diff
>
>
> Quickstart attached. To reproduce:
> 1) Open the homepage
> 2) Enter something on the second field and click submit
> 3) An error is displayed - the first field is required
> 4) Click changeModel (that doesn't submit the form)
> 5) The labels update, but the textfields doesn't
> Also attached a patch that seems to fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2021) When a form is not valid, the
textfields become with "raw input" and can't change its model on subsequent
requests
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664382#action_12664382 ]
Adriano dos Santos Fernandes commented on WICKET-2021:
------------------------------------------------------
Oops, sorry!
It's really clearing after click on submit.
> When a form is not valid, the textfields become with "raw input" and can't change its model on subsequent requests
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2021
> URL: https://issues.apache.org/jira/browse/WICKET-2021
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.5-M1
>
> Attachments: formvalidationtest.tar.gz, patch.diff
>
>
> Quickstart attached. To reproduce:
> 1) Open the homepage
> 2) Enter something on the second field and click submit
> 3) An error is displayed - the first field is required
> 4) Click changeModel (that doesn't submit the form)
> 5) The labels update, but the textfields doesn't
> Also attached a patch that seems to fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2021) When a form is not valid, the
textfields become with "raw input" and can't change its model on subsequent
requests
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664390#action_12664390 ]
Igor Vaynberg commented on WICKET-2021:
---------------------------------------
now its an enhancement and not a bug. those should be proposed on the list.
> When a form is not valid, the textfields become with "raw input" and can't change its model on subsequent requests
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2021
> URL: https://issues.apache.org/jira/browse/WICKET-2021
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.5-M1
>
> Attachments: formvalidationtest.tar.gz, patch.diff
>
>
> Quickstart attached. To reproduce:
> 1) Open the homepage
> 2) Enter something on the second field and click submit
> 3) An error is displayed - the first field is required
> 4) Click changeModel (that doesn't submit the form)
> 5) The labels update, but the textfields doesn't
> Also attached a patch that seems to fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2021) When a form is not valid, the
textfields become with "raw input" and can't change its model on subsequent
requests
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664375#action_12664375 ]
Matej Knopp commented on WICKET-2021:
-------------------------------------
Also you can call clearInput on form - that will clear input on all form components within the form
> When a form is not valid, the textfields become with "raw input" and can't change its model on subsequent requests
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2021
> URL: https://issues.apache.org/jira/browse/WICKET-2021
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.5-M1
>
> Attachments: formvalidationtest.tar.gz, patch.diff
>
>
> Quickstart attached. To reproduce:
> 1) Open the homepage
> 2) Enter something on the second field and click submit
> 3) An error is displayed - the first field is required
> 4) Click changeModel (that doesn't submit the form)
> 5) The labels update, but the textfields doesn't
> Also attached a patch that seems to fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2021) When a form is not valid, the
textfields become with "raw input" and can't change its model on subsequent
requests
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adriano dos Santos Fernandes updated WICKET-2021:
-------------------------------------------------
Attachment: formvalidationtest.tar.gz
Quickstart.
> When a form is not valid, the textfields become with "raw input" and can't change its model on subsequent requests
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2021
> URL: https://issues.apache.org/jira/browse/WICKET-2021
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Adriano dos Santos Fernandes
> Attachments: formvalidationtest.tar.gz, patch.diff
>
>
> Quickstart attached. To reproduce:
> 1) Open the homepage
> 2) Enter something on the second field and click submit
> 3) An error is displayed - the first field is required
> 4) Click changeModel (that doesn't submit the form)
> 5) The labels update, but the textfields doesn't
> Also attached a patch that seems to fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2021) When a form is not valid, the
textfields become with "raw input" and can't change its model on subsequent
requests
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adriano dos Santos Fernandes updated WICKET-2021:
-------------------------------------------------
Attachment: patch.diff
Patch.
> When a form is not valid, the textfields become with "raw input" and can't change its model on subsequent requests
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2021
> URL: https://issues.apache.org/jira/browse/WICKET-2021
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Adriano dos Santos Fernandes
> Attachments: formvalidationtest.tar.gz, patch.diff
>
>
> Quickstart attached. To reproduce:
> 1) Open the homepage
> 2) Enter something on the second field and click submit
> 3) An error is displayed - the first field is required
> 4) Click changeModel (that doesn't submit the form)
> 5) The labels update, but the textfields doesn't
> Also attached a patch that seems to fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2021) When a form is not valid, the
textfields become with "raw input" and can't change its model on subsequent
requests
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2021.
-----------------------------------
Resolution: Invalid
Fix Version/s: 1.5-M1
Assignee: Igor Vaynberg
what you see is the intended behavior. if the component is in error it preserves its raw input until it can be validated.
if you wish to change the model object of an invalid component and wish it to reflect the new value you should call clearinput() manually.
if we apply your patch then all invalid components would always lose their input and be redrawn blank, obviously not something we want.
> When a form is not valid, the textfields become with "raw input" and can't change its model on subsequent requests
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2021
> URL: https://issues.apache.org/jira/browse/WICKET-2021
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.5-M1
>
> Attachments: formvalidationtest.tar.gz, patch.diff
>
>
> Quickstart attached. To reproduce:
> 1) Open the homepage
> 2) Enter something on the second field and click submit
> 3) An error is displayed - the first field is required
> 4) Click changeModel (that doesn't submit the form)
> 5) The labels update, but the textfields doesn't
> Also attached a patch that seems to fix the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.