[GitHub] [solr] epugh commented on a diff in pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1248:
URL: https://github.com/apache/solr/pull/1248#discussion_r1057979692


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -97,6 +97,7 @@ protected CloudHttp2SolrClient(Builder builder) {
     } else {
       this.stateProvider = builder.stateProvider;
     }
+    this.setParallelCacheRefreshesLocks(builder.parallelCacheRefreshesLocks);

Review Comment:
   yeah, what @stillalex  said is why I added this extra method.....   However, if it's an expert setting system property, then we could remove all of this right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org