You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/08/06 08:00:23 UTC
Review Request 68214: Updated `volume/sandbox_path` isolator to honor
volume mode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68214/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814
Repository: mesos
Description
-------
Updated `volume/sandbox_path` isolator to honor volume mode.
Diffs
-----
src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 4896c6811c2c59dcf00871b7a8b6b9b50da0f062
Diff: https://reviews.apache.org/r/68214/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68214: Updated `volume/sandbox_path` isolator to
honor volume mode.
Posted by Qian Zhang <zh...@gmail.com>.
> On Aug. 13, 2018, 12:15 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp
> > Line 373 (original), 373 (patched)
> > <https://reviews.apache.org/r/68214/diff/2/?file=2069910#file2069910line373>
> >
> > Not yours, but could we remove this?
I think we still need to keep it. Otherwise, the code in it may fail to compile on platforms other than Linux because those codes use some Linux specific macros, like `MS_BIND`.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68214/#review207135
-----------------------------------------------------------
On Aug. 7, 2018, 10:18 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68214/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 10:18 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `volume/sandbox_path` isolator to honor volume mode.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 4896c6811c2c59dcf00871b7a8b6b9b50da0f062
>
>
> Diff: https://reviews.apache.org/r/68214/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68214: Updated `volume/sandbox_path` isolator to
honor volume mode.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68214/#review207135
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp
Line 373 (original), 373 (patched)
<https://reviews.apache.org/r/68214/#comment290359>
Not yours, but could we remove this?
- Gilbert Song
On Aug. 7, 2018, 7:18 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68214/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 7:18 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `volume/sandbox_path` isolator to honor volume mode.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 4896c6811c2c59dcf00871b7a8b6b9b50da0f062
>
>
> Diff: https://reviews.apache.org/r/68214/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68214: Updated `volume/sandbox_path` isolator to
honor volume mode.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68214/
-----------------------------------------------------------
(Updated Aug. 7, 2018, 10:18 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814
Repository: mesos
Description
-------
Updated `volume/sandbox_path` isolator to honor volume mode.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 4896c6811c2c59dcf00871b7a8b6b9b50da0f062
Diff: https://reviews.apache.org/r/68214/diff/2/
Changes: https://reviews.apache.org/r/68214/diff/1-2/
Testing
-------
Thanks,
Qian Zhang