[GitHub] [ozone] elek commented on a change in pull request #1555: HDDS-4347.Make Ozone specific Trash remover multi threaded

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #1555:
URL: https://github.com/apache/ozone/pull/1555#discussion_r536560375



##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -1907,6 +1907,15 @@
     </description>
   </property>
 
+  <property>

Review comment:
       Can you please use Java, annotation based configuration?

##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashPolicyOzone.java
##########
@@ -115,20 +128,23 @@ public void run() {
           now = Time.now();
           if (now >= end) {
             Collection<FileStatus> trashRoots;
-            trashRoots = fs.getTrashRoots(true);      // list all trash dirs
-
-            for (FileStatus trashRoot : trashRoots) {   // dump each trash
+            trashRoots = fs.getTrashRoots(true); // list all trash dirs

Review comment:
       I know it's committed in the previous commit, but can you please help me to understand why do we need FileSystem in OM side? As far as I understood the design doc has more cons against this approach.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org