You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "serrislew (via GitHub)" <gi...@apache.org> on 2023/09/21 23:15:31 UTC
[GitHub] [trafficserver] serrislew opened a new pull request, #10491: Coverity 1518592: check cachekey valid
serrislew opened a new pull request, #10491:
URL: https://github.com/apache/trafficserver/pull/10491
Fixes #10345 by checking cachekey is valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew merged pull request #10491: Coverity 1518592: check cachekey valid
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew merged PR #10491:
URL: https://github.com/apache/trafficserver/pull/10491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #10491: Coverity 1518592: check cachekey valid
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #10491:
URL: https://github.com/apache/trafficserver/pull/10491#issuecomment-1730488315
I'm generally fine with this, except, makes you wonder how we are even starting up with a configuration that could create broken (invalid) cache keys? Seems we ought to error out if so, rather than just marking it invalid ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew commented on pull request #10491: Coverity 1518592: check cachekey valid
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew commented on PR #10491:
URL: https://github.com/apache/trafficserver/pull/10491#issuecomment-1730512724
@zwoop that's true but this is called on `TSRemapDoRemap` when the transaction is called so this is after starting up, so would we want to error out (stop ATS) for this case? is that better than just skipping the config?
I guess you mean by checking the configs before each reaching this point but it also seems like it can be invalid despite the configs [TSHttpTxnPristineUrlGet()](https://github.com/apache/trafficserver/blob/master/plugins/cachekey/cachekey.cc#L257-L260)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org