You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jaepil (via GitHub)" <gi...@apache.org> on 2024/07/16 13:38:44 UTC
[PR] MINOR: [C++] Fix compiler warnings in Clang [arrow]
jaepil opened a new pull request, #43278:
URL: https://github.com/apache/arrow/pull/43278
This PR fixes compiler warnings in Clang.
```
❯ ninja clean && ninja
[1/1] Cleaning all built files...
Cleaning... 0 files.
[289/391] Building CXX object src/arrow/acero/CMakeFiles/arrow_acero_objlib.dir/asof_join_node.cc.o
/Users/jaepil/work/appspand/deps/arrow/cpp/src/arrow/acero/asof_join_node.cc:782:17: warning: private field 'node_' is not used [-Wunused-private-field]
782 | AsofJoinNode* node_;
| ^
/Users/jaepil/work/appspand/deps/arrow/cpp/src/arrow/acero/asof_join_node.cc:784:10: warning: private field 'index_' is not used [-Wunused-private-field]
784 | size_t index_;
| ^
2 warnings generated.
[391/391] Linking CXX static library release/libarrow_substrait.a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Fix compiler warnings in Clang [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43278:
URL: https://github.com/apache/arrow/pull/43278#issuecomment-2231845866
Could you open a new issue for this?
This is not a MINOR change. See also our MINOR definition: https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes
Could you use our PR template instead of removing it entirely?
Could you show how to reproduce this?
What is your Clang version? How did you run `cmake`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Fix compiler warnings in Clang [arrow]
Posted by "jaepil (via GitHub)" <gi...@apache.org>.
jaepil commented on PR #43278:
URL: https://github.com/apache/arrow/pull/43278#issuecomment-2232434025
> Could you open a new issue for this? This is not a MINOR change. See also our MINOR definition: https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes
>
> Could you use our PR template instead of removing it entirely?
>
> Could you show how to reproduce this? What is your Clang version? How did you run `cmake`?
No problem. I should have read the `CONTRIBUTING.md` more carefully. I will update the PR description and create an issue later today.
Thanks for the feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Fix compiler warnings in Clang [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #43278:
URL: https://github.com/apache/arrow/pull/43278#issuecomment-2450248571
@zanmato1984 so these two members are only used in debug mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Fix compiler warnings in Clang [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #43278: MINOR: [C++] Fix compiler warnings in Clang
URL: https://github.com/apache/arrow/pull/43278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Fix compiler warnings in Clang [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43278:
URL: https://github.com/apache/arrow/pull/43278#issuecomment-3789782948
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Fix compiler warnings in Clang [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #43278:
URL: https://github.com/apache/arrow/pull/43278#discussion_r1680429003
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -779,9 +779,9 @@ class InputState {
// Hasher for key elements
mutable KeyHasher* key_hasher_;
// Owning node
Review Comment:
```suggestion
#ifndef NDEBUG
// Owning node
```
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -779,9 +779,9 @@ class InputState {
// Hasher for key elements
mutable KeyHasher* key_hasher_;
// Owning node
- AsofJoinNode* node_;
+ [[maybe_unused]] AsofJoinNode* node_;
Review Comment:
```suggestion
AsofJoinNode* node_;
```
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -779,9 +779,9 @@ class InputState {
// Hasher for key elements
mutable KeyHasher* key_hasher_;
// Owning node
- AsofJoinNode* node_;
+ [[maybe_unused]] AsofJoinNode* node_;
// Index of this input
- size_t index_;
+ [[maybe_unused]] size_t index_;
Review Comment:
```suggestion
size_t index_;
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Fix compiler warnings in Clang [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #43278:
URL: https://github.com/apache/arrow/pull/43278#issuecomment-2450308325
> @zanmato1984 so these two members are only used in debug mode?
Yes, I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org