You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by GitBox <gi...@apache.org> on 2023/01/05 08:17:19 UTC

[GitHub] [hop] hansva opened a new issue, #2129: [Feature Request]: Refactor the usage of JDBC Drivers

hansva opened a new issue, #2129:
URL: https://github.com/apache/hop/issues/2129

   ### What would you like to happen?
   
   **As is:**
   
   Currently when creating transforms that need a JDBC driver the driver has to be included either in the plugin lib folder or the lib/core folder. If the driver is already present in the database type we have to move the transform plugins together with the database type to avoid duplicating JDBC drivers or move the driver one classloader up to lib/core. This is all very confusing to the end user.
   
   It even gets more complex when the user uses HOP_SHARED_JDBC_FOLDER, the drivers in this folder are only loaded by database plugin types and Transform/Action types have no access to them, so when using a Transform or Action that requires a JDBC driver you have to move it from the HOP_SHARED_JDBC_FOLDER to lib/core (or the plugins) to make it work.
   
   
   **To be:**
   
   Make the way we package and use JDBC drivers more user-friendly and transparent to the user
   
   **Proposed solution:**
   
   I propose the following solution to tackle the problem. I think we should move all JDBC drivers from the database/plugin types to a central folder /lib/jdbc and change the way the HOP_SHARED_JDBC_FOLDER variable works it should accept a list of folder locations and default to /lib/jdbc (thus renaming it to HOP_SHARED_JDBC_FOLDER**S**)
   
   The Database types should use this variable as default (as they do now) so not much will change there.
   The Action/Transform annotations should receive a new option (includeJdbc default:false) and when this is set to true the plugin classloader will include the classes from the HOP_SHARED_JDBC_FOLDERS variable.
   
   
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: Transforms


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva commented on issue #2129: [Feature Request]: Refactor the usage of JDBC Drivers

Posted by GitBox <gi...@apache.org>.
hansva commented on issue #2129:
URL: https://github.com/apache/hop/issues/2129#issuecomment-1371924649

   Side note, as upgrade/backwards compatibility path we can keep the current HOP_SHARED_JDBC_FOLDER variable and add logic in the startup scripts to append the value to HOP_SHARED_JDBC_FOLDER**S**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature Request]: Refactor the usage of JDBC Drivers (hop)

Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on issue #2129:
URL: https://github.com/apache/hop/issues/2129#issuecomment-1732583302

   .take-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature Request]: Refactor the usage of JDBC Drivers (hop)

Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva closed issue #2129: [Feature Request]: Refactor the usage of JDBC Drivers
URL: https://github.com/apache/hop/issues/2129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org