You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/20 18:56:47 UTC
[GitHub] [hadoop-ozone] adoroszlai commented on issue #572: HDDS-3045.
Integration test crashes due to ReconServer NPE
adoroszlai commented on issue #572: HDDS-3045. Integration test crashes due to ReconServer NPE
URL: https://github.com/apache/hadoop-ozone/pull/572#issuecomment-589252149
`ReconServer extends GenericCli`, whose `run()` calls `System.exit()` in case of exceptions, which explains the "crash". If the proposed change in `ReconServer` is not considered safe, alternative fix would be:
```diff
diff --git hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java
index 7bd6eaec7..a359d675c 100644
--- hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java
+++ hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java
@@ -297,7 +297,7 @@ public void restartReconServer() {
reconServer.stop();
reconServer.join();
reconServer = new ReconServer();
- reconServer.run(new String[]{});
+ reconServer.execute(new String[]{});
} catch (Exception e) {
LOG.info("Exception while restarting Recon", e);
}
@@ -516,7 +516,7 @@ public MiniOzoneCluster build() throws IOException {
if (startDataNodes) {
cluster.startHddsDatanodes();
}
- reconServer.run(new String[] {});
+ reconServer.execute(new String[] {});
return cluster;
} catch (Exception ex) {
stopOM(om);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org