You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/11 09:21:07 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #27063: AIP-50 Trigger UI based on FAB

ashb commented on code in PR #27063:
URL: https://github.com/apache/airflow/pull/27063#discussion_r1066752407


##########
airflow/config_templates/config.yml:
##########
@@ -1529,6 +1529,19 @@ webserver:
       type: boolean
       example: ~
       default: "False"
+    trigger_dag_url:

Review Comment:
   Why do we need this btw? (As in when would someone ever set it?)
   
   I'm wary about hard-coding URLs like this in the  config, as this would need extra config if someone sets the webserver root to something other than `/` -- i.e. why can't we use `{{ url_for(..., dag_id=...) }}` in the template>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org