You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/05/02 13:47:28 UTC
[GitHub] [hive] kasakrisz opened a new pull request, #3045: HIVE-25969: Unable to reference table column named default
kasakrisz opened a new pull request, #3045:
URL: https://github.com/apache/hive/pull/3045
### What changes were proposed in this pull request?
Introduce parser token and rule for `default` keyword.
Use the Token in SemanticAnalyzers when replacing `default` keyword with default constraint values.
### Why are the changes needed?
Prior this patch
* the `default` keyword was treated as an identifier.
* and the lookup in the sql text was done by exact match of the string `default` in some cases.
### Does this PR introduce _any_ user-facing change?
Yes, see jira for example.
### How was this patch tested?
```
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=insert_into_default_keyword.q,insert_into_default_keyword_2.q -pl itests/qtest -Pitests
mvn test -Dtest=TestParseDefault -pl parser
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3045: HIVE-25969: Unable to reference table column named default
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3045:
URL: https://github.com/apache/hive/pull/3045#issuecomment-1107671566
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3045: HIVE-25969: Unable to reference table column named default
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3045: HIVE-25969: Unable to reference table column named default
URL: https://github.com/apache/hive/pull/3045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz merged pull request #3045: HIVE-25969: Unable to reference table column named default
Posted by GitBox <gi...@apache.org>.
kasakrisz merged PR #3045:
URL: https://github.com/apache/hive/pull/3045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org