You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/29 07:44:01 UTC

[GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1418: [IOTDB-778] Do not handle measurement name with quotaion uniformly

SilverNarcissus commented on a change in pull request #1418:
URL: https://github.com/apache/incubator-iotdb/pull/1418#discussion_r446830303



##########
File path: tsfile/src/test/java/org/apache/iotdb/tsfile/read/common/PathTest.java
##########
@@ -41,7 +41,9 @@ public void construct() throws Exception {
     testPath(path, "", "", "");
     // with quote;
     path = new Path("root.d1.r1.\"x1.x2.x3\"");
-    testPath(path, "root.d1.r1", "x1.x2.x3", "root.d1.r1.\"x1.x2.x3\"");
+    testPath(path, "root.d1.r1", "\"x1.x2.x3\"", "root.d1.r1.\"x1.x2.x3\"");

Review comment:
       Also add some test about " in 'xxx' or ' in "xxx". It will make it more robust. Thanks~




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org