You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/10 16:54:49 UTC

[GitHub] [dubbo-go-hessian2] wongoo opened a new pull request #239: fix issue that cant decode java generic type

wongoo opened a new pull request #239:
URL: https://github.com/apache/dubbo-go-hessian2/pull/239


   <!--  Thanks for sending a pull request! 
   -->
   
   **What this PR does**:
   
   fix issue #238 that cant decode java generic type
   
   **Which issue(s) this PR fixes**:
   
   Fixes #238
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   
   ```release-note
   - fix issue that cant decode java generic type
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-hessian2] codecov-io edited a comment on pull request #239: fix issue that cant decode java generic type

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #239:
URL: https://github.com/apache/dubbo-go-hessian2/pull/239#issuecomment-706579565


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=h1) Report
   > Merging [#239](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/c0c78ba6b7fbf2a0be312b65baaa38ba08c0b8d4?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239/graphs/tree.svg?width=650&height=150&src=pr&token=Yh82j7lS1W)](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #239   +/-   ##
   =======================================
     Coverage   66.18%   66.18%           
   =======================================
     Files          25       25           
     Lines        2762     2768    +6     
   =======================================
   + Hits         1828     1832    +4     
   - Misses        707      708    +1     
   - Partials      227      228    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `65.60% <71.42%> (+0.02%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=footer). Last update [c0c78ba...4f94f8d](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-hessian2] codecov-io edited a comment on pull request #239: fix issue that cant decode java generic type

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #239:
URL: https://github.com/apache/dubbo-go-hessian2/pull/239#issuecomment-706579565


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=h1) Report
   > Merging [#239](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/c0c78ba6b7fbf2a0be312b65baaa38ba08c0b8d4?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239/graphs/tree.svg?width=650&height=150&src=pr&token=Yh82j7lS1W)](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #239   +/-   ##
   =======================================
     Coverage   66.18%   66.18%           
   =======================================
     Files          25       25           
     Lines        2762     2768    +6     
   =======================================
   + Hits         1828     1832    +4     
   - Misses        707      708    +1     
   - Partials      227      228    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `65.60% <71.42%> (+0.02%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=footer). Last update [c0c78ba...864791d](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-hessian2] AlexStocks merged pull request #239: fix issue that cant decode java generic type

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #239:
URL: https://github.com/apache/dubbo-go-hessian2/pull/239


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-hessian2] codecov-io commented on pull request #239: fix issue that cant decode java generic type

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #239:
URL: https://github.com/apache/dubbo-go-hessian2/pull/239#issuecomment-706579565


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=h1) Report
   > Merging [#239](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/c0c78ba6b7fbf2a0be312b65baaa38ba08c0b8d4?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239/graphs/tree.svg?width=650&height=150&src=pr&token=Yh82j7lS1W)](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #239   +/-   ##
   =======================================
     Coverage   66.18%   66.18%           
   =======================================
     Files          25       25           
     Lines        2762     2768    +6     
   =======================================
   + Hits         1828     1832    +4     
   - Misses        707      708    +1     
   - Partials      227      228    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `65.60% <71.42%> (+0.02%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=footer). Last update [c0c78ba...4f94f8d](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/239?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org