You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2011/04/28 16:41:03 UTC

[jira] [Created] (PIG-2019) smoketest-ar

smoketest-ar
------------

                 Key: PIG-2019
                 URL: https://issues.apache.org/jira/browse/PIG-2019
             Project: Pig
          Issue Type: Bug
            Reporter: Konstantin Boudnik




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Work started] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on PIG-2019 started by Konstantin Boudnik.

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.9.0
>
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Gates updated PIG-2019:
----------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.9.0)
                   0.10
           Status: Resolved  (was: Patch Available)

Patch checked in.  Thanks Cos.

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.10
>
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027820#comment-13027820 ] 

Konstantin Boudnik commented on PIG-2019:
-----------------------------------------

Right, I understand. I wanted to make sure that I am not missing any tests which can be run against a real cluster (e.g. smoke tests). Thanks.

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.10
>
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027769#comment-13027769 ] 

Alan Gates commented on PIG-2019:
---------------------------------

When I run ant smoketests-jar now, the resulting smoketests.jar contains:

{code}
META-INF/
META-INF/MANIFEST.MF
org/
org/apache/
org/apache/pig/
org/apache/pig/test/
org/apache/pig/test/pigunit/
org/apache/pig/test/pigunit/pig/
org/apache/pig/test/pigunit/TestPigTest.class
org/apache/pig/test/pigunit/pig/TestGruntParser$1.class
org/apache/pig/test/pigunit/pig/TestGruntParser.class
test/
test/data/
test/data/pigunit/
test/data/pigunit/top_queries.pig
test/data/pigunit/top_queries_expected_top_3.txt
test/data/pigunit/top_queries_input_data.txt
test/data/pigunit/top_queries_params.txt
{code}

Does that look correct? That seems a little thin.  Smoketest just runs the PigUnit tests?

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.9.0
>
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated PIG-2019:
------------------------------------

    Fix Version/s: 0.9.0
           Status: Patch Available  (was: In Progress)

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.9.0
>
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated PIG-2019:
------------------------------------

    Description: pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.
       Assignee: Konstantin Boudnik
        Summary: smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes  (was: smoketest-ar)

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated PIG-2019:
------------------------------------

          Component/s: build
    Affects Version/s: 0.9.0

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.9.0
>
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026329#comment-13026329 ] 

Konstantin Boudnik commented on PIG-2019:
-----------------------------------------

The easiest way to guarantee the presence of the compiled classes is to add a dependency to smoketests-jar target (see the patch).

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027782#comment-13027782 ] 

Konstantin Boudnik commented on PIG-2019:
-----------------------------------------

It seems to be right unless there any other tests which could be run against a real cluster that I missing. I thought that PigUnit was a framework right for this purpose, wasn't it?

Please correct me if I am wrong and I'd fix the patch accordingly.

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.9.0
>
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated PIG-2019:
------------------------------------

    Attachment: PIG-2019.patch

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2019) smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027814#comment-13027814 ] 

Alan Gates commented on PIG-2019:
---------------------------------

I'm not saying it's the wrong framework.  I just wanted to make sure this wasn't supposed to include some actual tests as well.

> smoketest-jar target has to depend on pigunit-jar to guarantee inclusion of test classes
> ----------------------------------------------------------------------------------------
>
>                 Key: PIG-2019
>                 URL: https://issues.apache.org/jira/browse/PIG-2019
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.9.0
>
>         Attachments: PIG-2019.patch
>
>
> pigsmoke artifact uses classes from pigunit for real cluster testing. However, in the deployment phase the artifact comes out without the classes added. It happens because of the execution order of targets during deployment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira