You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/03 20:22:58 UTC
[jira] [Commented] (METRON-538) Ensure proper shutdown, exceptions
of integration test components
[ https://issues.apache.org/jira/browse/METRON-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634121#comment-15634121 ]
ASF GitHub Bot commented on METRON-538:
---------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/incubator-metron/pull/344
METRON-538 (DO NOT MERGE) Ensure proper shutdown, exceptions of integration test components
This is an effort to eliminate spam errors from our testing and hopefully improve our testing at the same time.
This PR will track the commits for this effort, and allow for timely comment and review.
So far the things we are looking for or seeing are
- problems with shutdown dependencies with the testing components like yarn and zk
- problems were we cannot completely mock out components. Even if the tests pass, we are spammed with errors because of the attempts to connect to components that are part of the test because they are not needed.
My goal is to keep this PR mergable with every commit as I go.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/incubator-metron METRON-538
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/344.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #344
----
commit 6d230bada58bf297365b289affc375a48ce1da84
Author: Otto Fowler <of...@industrialdefender.com>
Date: 2016-11-03T17:44:32Z
In Maas Integration, be sure to shutdown zookeeper AFTER yarn, to avoid extra errors when shutting down yarn
commit fb79f16b71f781ba02c7c7b9ec33d17444bfe320
Author: Otto Fowler <of...@industrialdefender.com>
Date: 2016-11-03T19:46:29Z
Make HBaseBolt testable by allowing building with a provided table provider as opposed to building from string, this allows mocking. This eliminates log spam of errors when the runtime class still attempts and fails to connect to zookeeper, which is not running or needed for this test. I did not change the function for withTableProvider() because I do not know all the consequences of changing the flux configurations
----
> Ensure proper shutdown, exceptions of integration test components
> -----------------------------------------------------------------
>
> Key: METRON-538
> URL: https://issues.apache.org/jira/browse/METRON-538
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.2.2BETA
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Critical
>
> The integration test components use to test with kafka, in mem cluster and zookeeper can be left in a failed state, where they are not shut down and their resources released. This can lead to cascading failures in the testing environment and log pollution.
> The components and their use should be refactored such that they are always shut down properly, and log appropriately.
> Some examples will be added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)