[jira] [Commented] (ASTERIXDB-2672) Change the valid values for "format" request parameter

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ASTERIXDB-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969515#comment-16969515 ] 

ASF subversion and git services commented on ASTERIXDB-2672:
------------------------------------------------------------

Commit 97557a81bd4f1feee3d05e60148d89f5fa00f052 in asterixdb's branch refs/heads/master from Ali Alsuliman
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=97557a8 ]

[ASTERIXDB-2672][API] Change the valid values for "format" request parameter

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Allowed values for "format" request parameter: json, csv, adm.
- Recognizable format values in "Accept":
  application/x-adm
  application/json
  application/json;lossless=true/false
  text/csv
  text/csv;header=present/absent

Test framework changes:
- ResultExtractor: if the OutputFormat is json/lossless-json, print the "result"
  field of the response similar to how adm would be printed, one json value
  per line (and using same spacing).
- Changed some queries that use "EXPLAIN SELECT..." and specify OutputFormat as JSON.
  The queries extension is ".plans.sqlpp". "param optimized-logical-plan:string=true"
  is specified in those queries to print the logical plan in the "plans" field of
  the response.
- added "// compareunorderedarray=true" for test quries that use .regexjson to compare
  one json value against another where the order of elements in a json array is not
  deterministic.
- TestExecutor: OutputFormat.LOSSLESS_JSON & OutputFormat.CSV_HEADER formats are set
  in the "Accept". Otherwise, the desired format is set in the "format" request
  parameter as usual.
- TestHelper: changed "equalJson()" to allow comparing json array in two modes.
- Removed some test cases that used to set mime types in the "format" request parameter
  since now it's not allowed to do so.

Change-Id: Ie3c7a35446322c2d97679e7e724b9778e2a4ba83
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4043
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ali Alsuliman <al...@gmail.com>
Reviewed-by: Murtadha Hubail <mh...@apache.org>


> Change the valid values for "format" request parameter
> ------------------------------------------------------
>
>                 Key: ASTERIXDB-2672
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2672
>             Project: Apache AsterixDB
>          Issue Type: Bug
>          Components: API - HTTP API
>    Affects Versions: 0.9.4
>            Reporter: Ali Alsuliman
>            Assignee: Ali Alsuliman
>            Priority: Major
>             Fix For: 0.9.6
>
>
> Change the valid values for the "format" request parameter to be: "adm", "json", "csv".
> Mime-type formats are no longer allowed in the "format" request parameter. They are allowed in the "Accept" header. The recognizable mime types are:
>  * application/x-adm
>  * application/json
>  * application/json;lossless=true/false
>  * text/csv
>  * text/csv;header=present/absent



--
This message was sent by Atlassian Jira
(v8.3.4#803005)