You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2016/09/21 03:47:53 UTC
[GitHub] incubator-carbondata pull request #184: [CARBONDATA-264]Fixed limit query sc...
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/184
[CARBONDATA-264]Fixed limit query scan time statistics issue
Problem: Scan time is not logging in statistics in case of limit query
Soluntion: Moved statistics recording from iterator to queryExecutor finish method as in case of limit query after consuming records call is not coming to hasNext method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kumarvishal09/incubator-carbondata statisticsissue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit 60c92b08d642c9580533b5cf7cc27e0ecf84b244
Author: kumarvishal <ku...@gmail.com>
Date: 2016-09-21T03:37:09Z
Fixed limit query statistics issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #184: [CARBONDATA-264]Fixed limit query scan time...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/184
Build Failed, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #184: [CARBONDATA-264]Fixed limit query sc...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/184#discussion_r84940497
--- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/QueryExecutorProperties.java ---
@@ -91,5 +89,10 @@
* list of blocks in which query will be executed
*/
protected List<AbstractIndex> dataBlocks;
+ /**
+ * start time scanning
--- End diff --
it is the start time of scanning?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #184: [CARBONDATA-264]Fixed limit query sc...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/184#discussion_r84940346
--- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/DetailQueryExecutor.java ---
@@ -36,6 +36,7 @@
@Override public CarbonIterator<Object[]> execute(QueryModel queryModel)
throws QueryExecutionException {
List<BlockExecutionInfo> blockExecutionInfoList = getBlockExecutionInfos(queryModel);
+ queryProperties.scanStartTime=System.currentTimeMillis();
--- End diff --
incorrect code style
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---