You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/13 09:49:52 UTC
[GitHub] [iceberg] pan3793 opened a new pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
pan3793 opened a new pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331
As [suggested](https://github.com/apache/iceberg/pull/2296#issuecomment-797085585) by @aokolnychyi , we need to shade the runtime antlr4 dep and be independent from Spark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdsr commented on a change in pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
rdsr commented on a change in pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#discussion_r593940184
##########
File path: build.gradle
##########
@@ -1041,6 +1039,7 @@ project(':iceberg-spark3-runtime') {
relocate 'com.google', 'org.apache.iceberg.shaded.com.google'
relocate 'com.fasterxml', 'org.apache.iceberg.shaded.com.fasterxml'
relocate 'com.github.benmanes', 'org.apache.iceberg.shaded.com.github.benmanes'
+ relocate 'org.antlr.v4.runtime', 'org.apache.iceberg.shaded.org.antlr.v4.runtime'
Review comment:
I guess we don't bundle antlr in `iceberg-spark-runtime` hence no change there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
rymurr commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-800147489
The nessie plugin uses the gradle plugin portal which behind the scenes uses JCenter. According to this: https://blog.gradle.org/jcenter-shutdown they will behind the scenes move and not disrupt the plugins. Perhaps the failure was intermittent failure in JCenter?
```
Impact to Gradle plugins
Behind the scenes, the Gradle Plugin Portal uses JCenter to resolve dependencies of plugins. We will be migrating the Plugin Portal away from JCenter before the final shutdown. Builds will not need to make changes while the Plugin Portal migrates away from JCenter.
Resolving existing plugins
Existing plugins will continue to resolve in the same way they do today. No changes should need to be made to your builds.
Publishing new plugins
If you are publishing your plugin with the com.gradle.publish-plugin, you are not affected. Just double check that your build does not use JCenter directly.
If you are publishing your plugin to Bintray, you will need to use the com.gradle.publish-plugin plugin to publish new versions of your plugin. The sooner you can do this, the better. We can help if you have questions or problems.
We will automatically migrate all plugins published to Bintray on March 31, 2021. After that date, we will no longer synchronize plugins published to Bintray. This migration should be transparent to users resolving dependencies.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799888928
@snazy You published those artifacts right? I thought the 0.4 nessie build passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-800655075
Thank you, @pan3793! Thanks to everyone for reviewing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799877093
CI failed because `projectnessie`, could anyone have a look on it?
```
> Could not resolve org.projectnessie:org.projectnessie.gradle.plugin:0.4.0.
> Could not get resource 'https://jcenter.bintray.com/org/projectnessie/org.projectnessie.gradle.plugin/0.4.0/org.projectnessie.gradle.plugin-0.4.0.pom'.
> Could not HEAD 'https://jcenter.bintray.com/org/projectnessie/org.projectnessie.gradle.plugin/0.4.0/org.projectnessie.gradle.plugin-0.4.0.pom'.
> Read timed out
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 edited a comment on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799877093
CI failed because of `projectnessie`, could anyone have a look on it?
```
> Could not resolve org.projectnessie:org.projectnessie.gradle.plugin:0.4.0.
> Could not get resource 'https://jcenter.bintray.com/org/projectnessie/org.projectnessie.gradle.plugin/0.4.0/org.projectnessie.gradle.plugin-0.4.0.pom'.
> Could not HEAD 'https://jcenter.bintray.com/org/projectnessie/org.projectnessie.gradle.plugin/0.4.0/org.projectnessie.gradle.plugin-0.4.0.pom'.
> Read timed out
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799874698
@aokolnychyi Reverted, and I will open another PR to remove redundant spark-hive deps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on a change in pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#discussion_r593998428
##########
File path: build.gradle
##########
@@ -1041,6 +1039,7 @@ project(':iceberg-spark3-runtime') {
relocate 'com.google', 'org.apache.iceberg.shaded.com.google'
relocate 'com.fasterxml', 'org.apache.iceberg.shaded.com.fasterxml'
relocate 'com.github.benmanes', 'org.apache.iceberg.shaded.com.github.benmanes'
+ relocate 'org.antlr.v4.runtime', 'org.apache.iceberg.shaded.org.antlr.v4.runtime'
Review comment:
Yes, this change only affect `iceberg-spark3-runtime`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 edited a comment on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799874698
@aokolnychyi Reverted, and I will open another PR to remove redundant spark-hive deps
===
updated
see #2338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799833353
@pan3793, I agree about the hive dep but I'd like to handle that in a separate PR if possible. Let's keep this one specific to relocating the antlr4 dep.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 edited a comment on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799874698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-800067022
And JFrog announces [Into the Sunset on May 1st: Bintray, JCenter, GoCenter, and ChartCenter](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/), should we migrate to Maven Central? And consider there are some developers in Asia, we'd better make it easy to mirror by ENV VAR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799891926
Triggered the checks again.
cc @rymurr too for Nessie related failures
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799892671
I saw similar failures for other artifacts so should not be related to Nessie dep.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on a change in pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#discussion_r593729535
##########
File path: build.gradle
##########
@@ -1020,7 +1019,6 @@ project(':iceberg-spark3-runtime') {
compile project(':iceberg-spark3')
compile project(':iceberg-spark3-extensions')
compile project(':iceberg-aws')
- compile 'org.apache.spark:spark-hive_2.11'
Review comment:
Why it exists here? It should be excluded by
```
configurations {
compile {
exclude group: 'org.apache.spark'
...
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 edited a comment on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-799877093
jcenter seems not stable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on a change in pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#discussion_r593729535
##########
File path: build.gradle
##########
@@ -1020,7 +1019,6 @@ project(':iceberg-spark3-runtime') {
compile project(':iceberg-spark3')
compile project(':iceberg-spark3-extensions')
compile project(':iceberg-aws')
- compile 'org.apache.spark:spark-hive_2.11'
Review comment:
Why it exists here? It should be excluded by
```
configurations {
compile {
exclude group: 'org.apache.spark'
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] snazy commented on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
snazy commented on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-800051880
Tried it locally after purging all Nessie artifacts from both local Maven repo and Gradle cache and works fine.
All Nessie artifacts are published.
The jcenter repo often causes issues - maybe move it to the end in the `buildscript { repositories {}}` block in `build.gradle`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 edited a comment on pull request #2331: [BUILD] Relocate Antlr4 in spark3 runtime module
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2331:
URL: https://github.com/apache/iceberg/pull/2331#issuecomment-800067022
And JFrog announces [Into the Sunset on May 1st: Bintray, JCenter, GoCenter, and ChartCenter](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/), should we migrate to Maven Central? And consider there are some developers in Asia, we'd better make it easy to mirror by ENV VAR or gradle properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org