You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/07/23 02:33:06 UTC
[GitHub] codecov-io commented on issue #2109: Optimize init LoadBalance in
cluster invokers
codecov-io commented on issue #2109: Optimize init LoadBalance in cluster invokers
URL: https://github.com/apache/incubator-dubbo/pull/2109#issuecomment-406922048
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2109?src=pr&el=h1) Report
> Merging [#2109](https://codecov.io/gh/apache/incubator-dubbo/pull/2109?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e22d18cfe89adb321239d53647d372de743df095?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `72.72%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2109?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2109 +/- ##
===========================================
- Coverage 54.19% 54.1% -0.09%
+ Complexity 5083 5078 -5
===========================================
Files 559 559
Lines 24908 24913 +5
Branches 4438 4437 -1
===========================================
- Hits 13499 13480 -19
- Misses 9377 9396 +19
- Partials 2032 2037 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2109?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/dubbo/rpc/cluster/support/AvailableCluster.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9BdmFpbGFibGVDbHVzdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...o/rpc/cluster/support/BroadcastClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Ccm9hZGNhc3RDbHVzdGVySW52b2tlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...o/rpc/cluster/support/AvailableClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9BdmFpbGFibGVDbHVzdGVySW52b2tlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...bo/rpc/cluster/support/AbstractClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9BYnN0cmFjdENsdXN0ZXJJbnZva2VyLmphdmE=) | `72.11% <100%> (+1.52%)` | `43 <4> (+2)` | :arrow_up: |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | `3% <0%> (ø)` | |
| [...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0Z1dHVyZUFkYXB0ZXIuamF2YQ==) | `58.06% <0%> (-6.46%)` | `3% <0%> (ø)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `61.25% <0%> (-5%)` | `22% <0%> (-1%)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
| [...e/dubbo/remoting/transport/netty4/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVyLmphdmE=) | `72.13% <0%> (-3.28%)` | `9% <0%> (-1%)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2109/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2109?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2109?src=pr&el=footer). Last update [e22d18c...1c371b7](https://codecov.io/gh/apache/incubator-dubbo/pull/2109?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org